From: Alexander Kurz <akurz@blala.de>
Date: Fri, 26 Feb 2016 22:38:50 +0000 (+0100)
Subject: flash/nor/faux.c: fixing check for failed malloc
X-Git-Tag: v0.10.0-rc1~243
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=ba7b6ddea469512ba8a34ae6342af858bf427b89;hp=34b32d613af913645bdb0b0e79f10bf0f302ff33

flash/nor/faux.c: fixing check for failed malloc

Error found by static code analysis using the semantic pattern
null_ref2/mini_null_ref2.cocci, see coccinellery.org

Change-Id: Ic817c29f0ccf2b41fc8f7d9a480ad30d6e5b7ab8
Signed-off-by: Alexander Kurz <akurz@blala.de>
Reviewed-on: http://openocd.zylin.com/3364
Tested-by: jenkins
Reviewed-by: Uwe Bonnes <bon@elektron.ikp.physik.tu-darmstadt.de>
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
---

diff --git a/src/flash/nor/faux.c b/src/flash/nor/faux.c
index 1fd1da216b..8198ef5214 100644
--- a/src/flash/nor/faux.c
+++ b/src/flash/nor/faux.c
@@ -50,7 +50,7 @@ FLASH_BANK_COMMAND_HANDLER(faux_flash_bank_command)
 		return ERROR_FAIL;
 	}
 	info->memory = malloc(bank->size);
-	if (info == NULL) {
+	if (info->memory == NULL) {
 		free(info);
 		LOG_ERROR("no memory for flash bank info");
 		return ERROR_FAIL;