From: Sergey A. Borshch Date: Thu, 3 Oct 2013 13:05:15 +0000 (+0300) Subject: fix lpc2000 flash programming fail. X-Git-Tag: v0.8.0-rc1~227 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=9b3e7fb888b6c913e0d2544a14c02d14c9293663 fix lpc2000 flash programming fail. some members of lpc2000_info structure sometimes used uninitialized (cmd51_can_64b for all LPC except LPC800 as example). Init allocated lpc2000_info structure with zeros to avoid this and similar bugs in the future. Note: maybe discarding all cmd51_can_XXXb fields and using cmd51_dst_boundary instead will be a better solution. Signed-off-by: Sergey A. Borshch Change-Id: Idf116a5b0bf4ea1c39ea0ce308ec2c13bfbd4d8c Reviewed-on: http://openocd.zylin.com/1676 Tested-by: jenkins Reviewed-by: Andreas Fritiofson Reviewed-by: Nemui Trinomius --- diff --git a/src/flash/nor/lpc2000.c b/src/flash/nor/lpc2000.c index 3962f305c8..12814aad16 100644 --- a/src/flash/nor/lpc2000.c +++ b/src/flash/nor/lpc2000.c @@ -559,7 +559,8 @@ FLASH_BANK_COMMAND_HANDLER(lpc2000_flash_bank_command) if (CMD_ARGC < 8) return ERROR_COMMAND_SYNTAX_ERROR; - struct lpc2000_flash_bank *lpc2000_info = malloc(sizeof(struct lpc2000_flash_bank)); + struct lpc2000_flash_bank *lpc2000_info = calloc(1, sizeof(*lpc2000_info)); + bank->driver_priv = lpc2000_info; if (strcmp(CMD_ARGV[6], "lpc2000_v1") == 0) {