From: Andreas Fritiofson Date: Tue, 15 Nov 2011 22:56:04 +0000 (+0100) Subject: bitq: remove a static variable X-Git-Tag: v0.6.0-rc1~429 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=9450da873ca2f6bff53bd64e0bebb99d0e340e6e bitq: remove a static variable in_buff is only ever set to field->in_value and that pointer is still available when the parsing is restarted so it could just as well be used directly, removing the need for the static variable. Change-Id: I3dd7a8315ed5c5bdc3bfb74044f89492bca9816c Signed-off-by: Andreas Fritiofson Reviewed-on: http://openocd.zylin.com/206 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/src/jtag/drivers/bitq.c b/src/jtag/drivers/bitq.c index 4e2dbc21c3..20aead70e2 100644 --- a/src/jtag/drivers/bitq.c +++ b/src/jtag/drivers/bitq.c @@ -44,7 +44,6 @@ static struct bitq_state bitq_in_state; void bitq_in_proc(void) { /* static information preserved between calls to increase performance */ - static uint8_t* in_buff; /* pointer to buffer for scanned data */ static int in_idx; /* index of byte being scanned */ static uint8_t in_mask; /* mask of next bit to be scanned */ @@ -68,7 +67,6 @@ void bitq_in_proc(void) /* initialize field scanning */ in_mask = 0x01; in_idx = 0; - in_buff = field->in_value; } /* field scanning */ @@ -82,9 +80,9 @@ void bitq_in_proc(void) return; } if (in_mask == 0x01) - in_buff[in_idx] = 0; + field->in_value[in_idx] = 0; if (tdo) - in_buff[in_idx] |= in_mask; + field->in_value[in_idx] |= in_mask; if (in_mask == 0x80) { in_mask = 0x01;