From: Salvador Arroyo Date: Sat, 2 Mar 2013 15:20:42 +0000 (+0100) Subject: mips: code cleanup in cp0 command handlers X-Git-Tag: v0.7.0-rc1~24 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=74db7f9681c960c18c1ce2e3d317d931aaefe713 mips: code cleanup in cp0 command handlers After calling mips32_cp0_read() nothing has been queued, the call to jtag_exec_queue() is unnecessary. Change-Id: Ie25438045a8e9b6b1b170df7b52609d45f284b5a Signed-off-by: Salvador Arroyo Reviewed-on: http://openocd.zylin.com/1190 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/src/target/mips32.c b/src/target/mips32.c index ab39e6e7f3..1aaa6d6d82 100644 --- a/src/target/mips32.c +++ b/src/target/mips32.c @@ -758,12 +758,9 @@ COMMAND_HANDLER(mips32_handle_cp0_command) cp0_reg); return ERROR_OK; } - retval = jtag_execute_queue(); - if (retval != ERROR_OK) - return retval; - command_print(CMD_CTX, "cp0 reg %" PRIi32 ", select %" PRIi32 ": %8.8" PRIx32, cp0_reg, cp0_sel, value); + } else if (CMD_ARGC == 3) { uint32_t value; COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], value); diff --git a/src/target/mips_m4k.c b/src/target/mips_m4k.c index 485f4e8c71..a055696b04 100644 --- a/src/target/mips_m4k.c +++ b/src/target/mips_m4k.c @@ -1194,12 +1194,9 @@ COMMAND_HANDLER(mips_m4k_handle_cp0_command) cp0_reg); return ERROR_OK; } - retval = jtag_execute_queue(); - if (retval != ERROR_OK) - return retval; - command_print(CMD_CTX, "cp0 reg %" PRIi32 ", select %" PRIi32 ": %8.8" PRIx32, cp0_reg, cp0_sel, value); + } else if (CMD_ARGC == 3) { uint32_t value; COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], value);