From: Tim Newsome <tim@sifive.com>
Date: Tue, 6 Mar 2018 21:13:35 +0000 (-0800)
Subject: Add complete JTAG debug logging.
X-Git-Tag: v0.11.0-rc1~591
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=462c01206692ead0287107772146f6cc467129f9

Add complete JTAG debug logging.

Sample output, with default_interface_jtag_execute_queue replaced by
dijeq to satisfy commit message line length check:
Debug: 646 18 core.c:847 dijeq(): JTAG IR SCAN to RUN/IDLE
Debug: 647 18 core.c:852 dijeq():   5b out: 11
Debug: 648 18 core.c:847 dijeq(): JTAG DR SCAN to RUN/IDLE
Debug: 649 18 core.c:852 dijeq():   40b out: 4400000001
Debug: 650 18 core.c:857 dijeq():   40b in: 4400000000

Signed-off-by: Tim Newsome <tim@sifive.com>
Change-Id: I014e9e3a77755413b36edfcede2ab8f6aa08061b
Reviewed-on: http://openocd.zylin.com/4451
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
---

diff --git a/src/jtag/core.c b/src/jtag/core.c
index 18956f24db..144cf94f7d 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -836,7 +836,75 @@ int default_interface_jtag_execute_queue(void)
 		return ERROR_FAIL;
 	}
 
-	return jtag->execute_queue();
+	int result = jtag->execute_queue();
+
+#if !BUILD_ZY1000
+	/* Only build this if we use a regular driver with a command queue.
+	 * Otherwise jtag_command_queue won't be found at compile/link time. Its
+	 * definition is in jtag/commands.c, which is only built/linked by
+	 * jtag/Makefile.am if MINIDRIVER_DUMMY || !MINIDRIVER, but those variables
+	 * aren't accessible here. */
+	struct jtag_command *cmd = jtag_command_queue;
+	while (debug_level >= LOG_LVL_DEBUG && cmd) {
+		switch (cmd->type) {
+			case JTAG_SCAN:
+				LOG_DEBUG_IO("JTAG %s SCAN to %s",
+						cmd->cmd.scan->ir_scan ? "IR" : "DR",
+						tap_state_name(cmd->cmd.scan->end_state));
+				for (int i = 0; i < cmd->cmd.scan->num_fields; i++) {
+					struct scan_field *field = cmd->cmd.scan->fields + i;
+					if (field->out_value) {
+						char *str = buf_to_str(field->out_value, field->num_bits, 16);
+						LOG_DEBUG_IO("  %db out: %s", field->num_bits, str);
+						free(str);
+					}
+					if (field->in_value) {
+						char *str = buf_to_str(field->in_value, field->num_bits, 16);
+						LOG_DEBUG_IO("  %db  in: %s", field->num_bits, str);
+						free(str);
+					}
+				}
+				break;
+			case JTAG_TLR_RESET:
+				LOG_DEBUG_IO("JTAG TLR RESET to %s",
+						tap_state_name(cmd->cmd.statemove->end_state));
+				break;
+			case JTAG_RUNTEST:
+				LOG_DEBUG_IO("JTAG RUNTEST %d cycles to %s",
+						cmd->cmd.runtest->num_cycles,
+						tap_state_name(cmd->cmd.runtest->end_state));
+				break;
+			case JTAG_RESET:
+				{
+					const char *reset_str[3] = {
+						"leave", "deassert", "assert"
+					};
+					LOG_DEBUG_IO("JTAG RESET %s TRST, %s SRST",
+							reset_str[cmd->cmd.reset->trst + 1],
+							reset_str[cmd->cmd.reset->srst + 1]);
+				}
+				break;
+			case JTAG_PATHMOVE:
+				LOG_DEBUG_IO("JTAG PATHMOVE (TODO)");
+				break;
+			case JTAG_SLEEP:
+				LOG_DEBUG_IO("JTAG SLEEP (TODO)");
+				break;
+			case JTAG_STABLECLOCKS:
+				LOG_DEBUG_IO("JTAG STABLECLOCKS (TODO)");
+				break;
+			case JTAG_TMS:
+				LOG_DEBUG_IO("JTAG TMS (TODO)");
+				break;
+			default:
+				LOG_ERROR("Unknown JTAG command: %d", cmd->type);
+				break;
+		}
+		cmd = cmd->next;
+	}
+#endif
+
+	return result;
 }
 
 void jtag_execute_queue_noclear(void)
@@ -1107,7 +1175,8 @@ static int jtag_examine_chain(void)
 
 		if ((idcode & 1) == 0) {
 			/* Zero for LSB indicates a device in bypass */
-			LOG_INFO("TAP %s does not have IDCODE", tap->dotted_name);
+			LOG_INFO("TAP %s does not have valid IDCODE (idcode=0x%x)",
+					tap->dotted_name, idcode);
 			tap->hasidcode = false;
 			tap->idcode = 0;