From: Paul Fertser Date: Sun, 14 Jan 2018 16:28:20 +0000 (+0300) Subject: flash: nor: jtagspi: fix jtagspi_read_status() warning X-Git-Tag: v0.11.0-rc1~1240 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=3c9bd7c6f30a34e3930e44dd2e8ce5f5a877b4eb;ds=sidebyside flash: nor: jtagspi: fix jtagspi_read_status() warning Clang static analyzer says that in certain cases "Assigned value is garbage or undefined" there. Change-Id: Ib35a4cf7a553ba9461270a0dc4c4b9b205091e73 Signed-off-by: Paul Fertser Reviewed-on: http://openocd.zylin.com/4338 Tested-by: jenkins --- diff --git a/src/flash/nor/jtagspi.c b/src/flash/nor/jtagspi.c index a05ff37865..a73812d88a 100644 --- a/src/flash/nor/jtagspi.c +++ b/src/flash/nor/jtagspi.c @@ -224,9 +224,10 @@ static int jtagspi_probe(struct flash_bank *bank) static void jtagspi_read_status(struct flash_bank *bank, uint32_t *status) { uint8_t buf; - jtagspi_cmd(bank, SPIFLASH_READ_STATUS, NULL, &buf, -8); - *status = buf; - /* LOG_DEBUG("status=0x%08" PRIx32, *status); */ + if (jtagspi_cmd(bank, SPIFLASH_READ_STATUS, NULL, &buf, -8) == ERROR_OK) { + *status = buf; + /* LOG_DEBUG("status=0x%08" PRIx32, *status); */ + } } static int jtagspi_wait(struct flash_bank *bank, int timeout_ms)