From: oharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Date: Sun, 30 Aug 2009 21:12:50 +0000 (+0000)
Subject: David Brownell <david-b@pacbell.net> Minor code bugfix: check right variable.
X-Git-Tag: v0.3.0-rc0~296
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=2a86a53c3fee54f1cd966b430de7980badadd880;ds=sidebyside

David Brownell <david-b@pacbell.net> Minor code bugfix: check right variable.
Via code review by Steve Grubb <sgrubb@redhat.com> 

Almost innocuous; this is value is checked later, this
check being wrong would make it check stack garbage.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2655 b42882b7-edfa-0310-969c-e2dbd0fdcd60
---

diff --git a/src/flash/davinci_nand.c b/src/flash/davinci_nand.c
index ffd35608df..29c9630050 100644
--- a/src/flash/davinci_nand.c
+++ b/src/flash/davinci_nand.c
@@ -663,7 +663,7 @@ static int davinci_nand_device_command(struct command_context_s *cmd_ctx,
 	}
 
 	aemif = strtoul(argv[4], &ep, 0);
-	if (*ep || chip == 0 || chip == ULONG_MAX) {
+	if (*ep || aemif == 0 || aemif == ULONG_MAX) {
 		LOG_ERROR("Invalid AEMIF controller address %s", argv[4]);
 		goto fail;
 	}