From: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Date: Sat, 21 Sep 2013 19:22:17 +0000 (+0200)
Subject: jlink: Replace crazy home cooked assertion with a real one
X-Git-Tag: v0.8.0-rc1~245
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=18fda50111ae7f70fd4e5d7651e8ebae9f7012f2

jlink: Replace crazy home cooked assertion with a real one

Change-Id: I83d66ddef34965dd94a0ff76aa1367cc9d19f2df
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1644
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
---

diff --git a/src/jtag/drivers/jlink.c b/src/jtag/drivers/jlink.c
index ae6a022aec..edf972575c 100644
--- a/src/jtag/drivers/jlink.c
+++ b/src/jtag/drivers/jlink.c
@@ -1348,11 +1348,7 @@ static void jlink_tap_append_step(int tms, int tdi)
 {
 	int index_var = tap_length / 8;
 
-	if (index_var >= JLINK_TAP_BUFFER_SIZE) {
-		LOG_ERROR("jlink_tap_append_step: overflow");
-		*(uint32_t *)0xFFFFFFFF = 0;
-		exit(-1);
-	}
+	assert(index_var < JLINK_TAP_BUFFER_SIZE);
 
 	int bit_index = tap_length % 8;
 	uint8_t bit = 1 << bit_index;