From: David Brownell Date: Mon, 7 Dec 2009 22:54:13 +0000 (-0800) Subject: ARM: use not armv4_5.h X-Git-Tag: v0.4.0-rc1~82 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=0a1b7dcfc40385f09b5eb088cd97d6ff25a5816d ARM: use not armv4_5.h Move most declarations in to and update users. What's left in the older file is stuff that I think should be removed ... the old register cache access stuff, which makes it awkward to support microcontroller profile (Cortex-M) cores. The armv4_5_run_algorithm() declaration was moved too, even though it's not yet as generic as it probably ought to be. Signed-off-by: David Brownell --- diff --git a/src/flash/nand/arm_io.c b/src/flash/nand/arm_io.c index 4c746757cf..0cd39c00ee 100644 --- a/src/flash/nand/arm_io.c +++ b/src/flash/nand/arm_io.c @@ -27,7 +27,7 @@ #include "core.h" #include "arm_io.h" #include -#include +#include #include diff --git a/src/flash/nand/orion.c b/src/flash/nand/orion.c index 01d4a082b3..b46ffaed1f 100644 --- a/src/flash/nand/orion.c +++ b/src/flash/nand/orion.c @@ -28,7 +28,7 @@ #include "imp.h" #include "arm_io.h" -#include +#include struct orion_nand_controller diff --git a/src/flash/nor/aduc702x.c b/src/flash/nor/aduc702x.c index 57018bb1df..211b54e759 100644 --- a/src/flash/nor/aduc702x.c +++ b/src/flash/nor/aduc702x.c @@ -27,7 +27,7 @@ #include #include #include -#include +#include static int aduc702x_build_sector_list(struct flash_bank *bank); diff --git a/src/flash/nor/cfi.c b/src/flash/nor/cfi.c index 1ab9341881..71270b99a9 100644 --- a/src/flash/nor/cfi.c +++ b/src/flash/nor/cfi.c @@ -26,7 +26,7 @@ #include "imp.h" #include "cfi.h" #include "non_cfi.h" -#include +#include #include #include diff --git a/src/flash/nor/lpc2900.c b/src/flash/nor/lpc2900.c index ce74bbbac4..13dd731c78 100644 --- a/src/flash/nor/lpc2900.c +++ b/src/flash/nor/lpc2900.c @@ -26,7 +26,7 @@ #include "imp.h" #include #include -#include +#include #include diff --git a/src/flash/nor/str7x.c b/src/flash/nor/str7x.c index ef693e9584..040097a013 100644 --- a/src/flash/nor/str7x.c +++ b/src/flash/nor/str7x.c @@ -26,7 +26,7 @@ #include "imp.h" #include "str7x.h" -#include +#include #include #include diff --git a/src/target/Makefile.am b/src/target/Makefile.am index bd7bf7ae25..f1d5d15c67 100644 --- a/src/target/Makefile.am +++ b/src/target/Makefile.am @@ -97,6 +97,7 @@ MIPS32_SRC = \ noinst_HEADERS = \ algorithm.h \ + arm.h \ arm_dpm.h \ arm_jtag.h \ arm_adi_v5.h \ diff --git a/src/target/arm.h b/src/target/arm.h new file mode 100644 index 0000000000..00dbe2d6f4 --- /dev/null +++ b/src/target/arm.h @@ -0,0 +1,206 @@ +/* + * Copyright (C) 2005 by Dominic Rath + * Dominic.Rath@gmx.de + * + * Copyright (C) 2008 by Spencer Oliver + * spen@spen-soft.co.uk + * + * Copyright (C) 2009 by Øyvind Harboe + * oyvind.harboe@zylin.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the + * Free Software Foundation, Inc., + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + */ +#ifndef ARM_H +#define ARM_H + +#include +#include + + +/** + * @file + * Holds the interface to ARM cores. + * + * At this writing, only "classic ARM" cores built on the ARMv4 register + * and mode model are supported. The Thumb2-only microcontroller profile + * support has not yet been integrated, affecting Cortex-M parts. + */ + +/** + * These numbers match the five low bits of the *PSR registers on + * "classic ARM" processors, which build on the ARMv4 processor + * modes and register set. + */ +enum arm_mode { + ARM_MODE_USR = 16, + ARM_MODE_FIQ = 17, + ARM_MODE_IRQ = 18, + ARM_MODE_SVC = 19, + ARM_MODE_ABT = 23, + ARM_MODE_MON = 26, + ARM_MODE_UND = 27, + ARM_MODE_SYS = 31, + ARM_MODE_ANY = -1 +}; + +const char *arm_mode_name(unsigned psr_mode); +bool is_arm_mode(unsigned psr_mode); + +/** The PSR "T" and "J" bits define the mode of "classic ARM" cores. */ +enum arm_state { + ARM_STATE_ARM, + ARM_STATE_THUMB, + ARM_STATE_JAZELLE, + ARM_STATE_THUMB_EE, +}; + +extern const char *arm_state_strings[]; + +#define ARM_COMMON_MAGIC 0x0A450A45 + +/** + * Represents a generic ARM core, with standard application registers. + * + * There are sixteen application registers (including PC, SP, LR) and a PSR. + * Cortex-M series cores do not support as many core states or shadowed + * registers as traditional ARM cores, and only support Thumb2 instructions. + */ +struct arm { + int common_magic; + struct reg_cache *core_cache; + + /** Handle to the CPSR; valid in all core modes. */ + struct reg *cpsr; + + /** Handle to the SPSR; valid only in core modes with an SPSR. */ + struct reg *spsr; + + /** Support for arm_reg_current() */ + const int *map; + + /** + * Indicates what registers are in the ARM state core register set. + * ARM_MODE_ANY indicates the standard set of 37 registers, + * seen on for example ARM7TDMI cores. ARM_MODE_MON indicates three + * more registers are shadowed, for "Secure Monitor" mode. + */ + enum arm_mode core_type; + + /** Record the current core mode: SVC, USR, or some other mode. */ + enum arm_mode core_mode; + + /** Record the current core state: ARM, Thumb, or otherwise. */ + enum arm_state core_state; + + /** Flag reporting unavailability of the BKPT instruction. */ + bool is_armv4; + + /** Flag reporting whether semihosting is active. */ + bool is_semihosting; + + /** Value to be returned by semihosting SYS_ERRNO request. */ + int semihosting_errno; + + /** Backpointer to the target. */ + struct target *target; + + /** Handle for the debug module, if one is present. */ + struct arm_dpm *dpm; + + /** Handle for the Embedded Trace Module, if one is present. */ + struct etm_context *etm; + + /* FIXME all these methods should take "struct arm *" not target */ + + /** Retrieve all core registers, for display. */ + int (*full_context)(struct target *target); + + /** Retrieve a single core register. */ + int (*read_core_reg)(struct target *target, struct reg *reg, + int num, enum arm_mode mode); + int (*write_core_reg)(struct target *target, struct reg *reg, + int num, enum arm_mode mode, uint32_t value); + + /** Read coprocessor register. */ + int (*mrc)(struct target *target, int cpnum, + uint32_t op1, uint32_t op2, + uint32_t CRn, uint32_t CRm, + uint32_t *value); + + /** Write coprocessor register. */ + int (*mcr)(struct target *target, int cpnum, + uint32_t op1, uint32_t op2, + uint32_t CRn, uint32_t CRm, + uint32_t value); + + void *arch_info; +}; + +/** Convert target handle to generic ARM target state handle. */ +static inline struct arm *target_to_arm(struct target *target) +{ + return target->arch_info; +} + +static inline bool is_arm(struct arm *arm) +{ + return arm && arm->common_magic == ARM_COMMON_MAGIC; +} + +struct arm_algorithm { + int common_magic; + + enum arm_mode core_mode; + enum arm_state core_state; +}; + +struct arm_reg { + int num; + enum arm_mode mode; + struct target *target; + struct arm *armv4_5_common; + uint32_t value; +}; + +struct reg_cache *arm_build_reg_cache(struct target *target, struct arm *arm); + +extern const struct command_registration arm_command_handlers[]; + +int arm_arch_state(struct target *target); +int arm_get_gdb_reg_list(struct target *target, + struct reg **reg_list[], int *reg_list_size); + +int arm_init_arch_info(struct target *target, struct arm *arm); + +/* REVISIT rename this once it's usable by ARMv7-M */ +int armv4_5_run_algorithm(struct target *target, + int num_mem_params, struct mem_param *mem_params, + int num_reg_params, struct reg_param *reg_params, + uint32_t entry_point, uint32_t exit_point, + int timeout_ms, void *arch_info); + +int arm_checksum_memory(struct target *target, + uint32_t address, uint32_t count, uint32_t *checksum); +int arm_blank_check_memory(struct target *target, + uint32_t address, uint32_t count, uint32_t *blank); + +void arm_set_cpsr(struct arm *arm, uint32_t cpsr); +struct reg *arm_reg_current(struct arm *arm, unsigned regnum); + +extern struct reg arm_gdb_dummy_fp_reg; +extern struct reg arm_gdb_dummy_fps_reg; + +#endif /* ARM_H */ diff --git a/src/target/arm11.h b/src/target/arm11.h index 421f8d185c..bce5bd9cd3 100644 --- a/src/target/arm11.h +++ b/src/target/arm11.h @@ -23,7 +23,7 @@ #ifndef ARM11_H #define ARM11_H -#include +#include #include #define ARM11_TAP_DEFAULT TAP_INVALID diff --git a/src/target/arm7_9_common.c b/src/target/arm7_9_common.c index 03071dfd7b..64a99fb4b8 100644 --- a/src/target/arm7_9_common.c +++ b/src/target/arm7_9_common.c @@ -39,6 +39,7 @@ #include "arm_semihosting.h" #include "algorithm.h" #include "register.h" +#include "armv4_5.h" /** diff --git a/src/target/arm7_9_common.h b/src/target/arm7_9_common.h index 7555bec21f..bce17ef694 100644 --- a/src/target/arm7_9_common.h +++ b/src/target/arm7_9_common.h @@ -29,7 +29,7 @@ #ifndef ARM7_9_COMMON_H #define ARM7_9_COMMON_H -#include +#include #include #define ARM7_9_COMMON_MAGIC 0x0a790a79 /**< */ diff --git a/src/target/arm_dpm.c b/src/target/arm_dpm.c index 406e30a289..bd9c5d1613 100644 --- a/src/target/arm_dpm.c +++ b/src/target/arm_dpm.c @@ -21,7 +21,7 @@ #include "config.h" #endif -#include "armv4_5.h" /* REVISIT to become arm.h */ +#include "arm.h" #include "arm_dpm.h" #include #include "register.h" diff --git a/src/target/arm_semihosting.c b/src/target/arm_semihosting.c index d448d54e80..f4244c84d1 100644 --- a/src/target/arm_semihosting.c +++ b/src/target/arm_semihosting.c @@ -34,6 +34,7 @@ #include "config.h" #endif +#include "arm.h" #include "armv4_5.h" #include "register.h" #include "arm_semihosting.h" diff --git a/src/target/arm_simulator.c b/src/target/arm_simulator.c index 443f29bf23..908c613313 100644 --- a/src/target/arm_simulator.c +++ b/src/target/arm_simulator.c @@ -24,6 +24,7 @@ #include "config.h" #endif +#include "arm.h" #include "armv4_5.h" #include "arm_disassembler.h" #include "arm_simulator.h" diff --git a/src/target/armv4_5.c b/src/target/armv4_5.c index 7fec97b58f..dce6d6a638 100644 --- a/src/target/armv4_5.c +++ b/src/target/armv4_5.c @@ -27,6 +27,7 @@ #include "config.h" #endif +#include "arm.h" #include "armv4_5.h" #include "arm_jtag.h" #include "breakpoints.h" diff --git a/src/target/armv4_5.h b/src/target/armv4_5.h index c8882ed758..bacdb72e65 100644 --- a/src/target/armv4_5.h +++ b/src/target/armv4_5.h @@ -26,39 +26,10 @@ #ifndef ARMV4_5_H #define ARMV4_5_H -#include -#include - - -/** - * These numbers match the five low bits of the *PSR registers on - * "classic ARM" processors, which build on the ARMv4 processor - * modes and register set. +/* This stuff "knows" that its callers aren't talking + * to microcontroller profile (current Cortex-M) parts. + * We want to phase it out so core code can be shared. */ -enum arm_mode { - ARM_MODE_USR = 16, - ARM_MODE_FIQ = 17, - ARM_MODE_IRQ = 18, - ARM_MODE_SVC = 19, - ARM_MODE_ABT = 23, - ARM_MODE_MON = 26, - ARM_MODE_UND = 27, - ARM_MODE_SYS = 31, - ARM_MODE_ANY = -1 -}; - -const char *arm_mode_name(unsigned psr_mode); -bool is_arm_mode(unsigned psr_mode); - -/** The PSR "T" and "J" bits define the mode of "classic ARM" cores. */ -enum arm_state { - ARM_STATE_ARM, - ARM_STATE_THUMB, - ARM_STATE_JAZELLE, - ARM_STATE_THUMB_EE, -}; - -extern const char *arm_state_strings[]; /* OBSOLETE, DO NOT USE IN NEW CODE! The "number" of an arm_mode is an * index into the armv4_5_core_reg_map array. Its remaining users are @@ -76,140 +47,4 @@ extern const int armv4_5_core_reg_map[8][17]; /* offset into armv4_5 core register cache -- OBSOLETE, DO NOT USE! */ enum { ARMV4_5_CPSR = 31, }; -#define ARM_COMMON_MAGIC 0x0A450A45 - -/** - * Represents a generic ARM core, with standard application registers. - * - * There are sixteen application registers (including PC, SP, LR) and a PSR. - * Cortex-M series cores do not support as many core states or shadowed - * registers as traditional ARM cores, and only support Thumb2 instructions. - */ -struct arm -{ - int common_magic; - struct reg_cache *core_cache; - - /** Handle to the CPSR; valid in all core modes. */ - struct reg *cpsr; - - /** Handle to the SPSR; valid only in core modes with an SPSR. */ - struct reg *spsr; - - /** Support for arm_reg_current() */ - const int *map; - - /** - * Indicates what registers are in the ARM state core register set. - * ARM_MODE_ANY indicates the standard set of 37 registers, - * seen on for example ARM7TDMI cores. ARM_MODE_MON indicates three - * more registers are shadowed, for "Secure Monitor" mode. - */ - enum arm_mode core_type; - - /** Record the current core mode: SVC, USR, or some other mode. */ - enum arm_mode core_mode; - - /** Record the current core state: ARM, Thumb, or otherwise. */ - enum arm_state core_state; - - /** Flag reporting unavailability of the BKPT instruction. */ - bool is_armv4; - - /** Flag reporting whether semihosting is active. */ - bool is_semihosting; - - /** Value to be returned by semihosting SYS_ERRNO request. */ - int semihosting_errno; - - /** Backpointer to the target. */ - struct target *target; - - /** Handle for the debug module, if one is present. */ - struct arm_dpm *dpm; - - /** Handle for the Embedded Trace Module, if one is present. */ - struct etm_context *etm; - - /* FIXME all these methods should take "struct arm *" not target */ - - /** Retrieve all core registers, for display. */ - int (*full_context)(struct target *target); - - /** Retrieve a single core register. */ - int (*read_core_reg)(struct target *target, struct reg *reg, - int num, enum arm_mode mode); - int (*write_core_reg)(struct target *target, struct reg *reg, - int num, enum arm_mode mode, uint32_t value); - - /** Read coprocessor register. */ - int (*mrc)(struct target *target, int cpnum, - uint32_t op1, uint32_t op2, - uint32_t CRn, uint32_t CRm, - uint32_t *value); - - /** Write coprocessor register. */ - int (*mcr)(struct target *target, int cpnum, - uint32_t op1, uint32_t op2, - uint32_t CRn, uint32_t CRm, - uint32_t value); - - void *arch_info; -}; - -/** Convert target handle to generic ARM target state handle. */ -static inline struct arm *target_to_arm(struct target *target) -{ - return target->arch_info; -} - -static inline bool is_arm(struct arm *arm) -{ - return arm && arm->common_magic == ARM_COMMON_MAGIC; -} - -struct arm_algorithm -{ - int common_magic; - - enum arm_mode core_mode; - enum arm_state core_state; -}; - -struct arm_reg -{ - int num; - enum arm_mode mode; - struct target *target; - struct arm *armv4_5_common; - uint32_t value; -}; - -struct reg_cache *arm_build_reg_cache(struct target *target, struct arm *arm); - -int arm_arch_state(struct target *target); -int arm_get_gdb_reg_list(struct target *target, - struct reg **reg_list[], int *reg_list_size); - -extern const struct command_registration arm_command_handlers[]; - -int arm_init_arch_info(struct target *target, struct arm *arm); - -int armv4_5_run_algorithm(struct target *target, - int num_mem_params, struct mem_param *mem_params, - int num_reg_params, struct reg_param *reg_params, - uint32_t entry_point, uint32_t exit_point, - int timeout_ms, void *arch_info); - -int arm_checksum_memory(struct target *target, - uint32_t address, uint32_t count, uint32_t *checksum); -int arm_blank_check_memory(struct target *target, - uint32_t address, uint32_t count, uint32_t *blank); - -void arm_set_cpsr(struct arm *arm, uint32_t cpsr); -struct reg *arm_reg_current(struct arm *arm, unsigned regnum); - -extern struct reg arm_gdb_dummy_fp_reg; -extern struct reg arm_gdb_dummy_fps_reg; - #endif /* ARMV4_5_H */ diff --git a/src/target/armv7a.h b/src/target/armv7a.h index 24ec819858..663e5d92d1 100644 --- a/src/target/armv7a.h +++ b/src/target/armv7a.h @@ -20,7 +20,7 @@ #define ARMV7A_H #include -#include +#include #include #include #include @@ -114,22 +114,6 @@ target_to_armv7a(struct target *target) /* See ARMv7a arch spec section C10.8 */ #define CPUDBG_AUTHSTATUS 0xFB8 -struct armv7a_algorithm -{ - int common_magic; - - enum arm_mode core_mode; - enum arm_state core_state; -}; - -struct armv7a_core_reg -{ - int num; - enum arm_mode mode; - struct target *target; - struct armv7a_common *armv7a_common; -}; - int armv7a_arch_state(struct target *target); struct reg_cache *armv7a_build_reg_cache(struct target *target, struct armv7a_common *armv7a_common); diff --git a/src/target/armv7m.h b/src/target/armv7m.h index c60ab8cfff..f662e16266 100644 --- a/src/target/armv7m.h +++ b/src/target/armv7m.h @@ -27,7 +27,7 @@ #define ARMV7M_COMMON_H #include -#include +#include /* define for enabling armv7 gdb workarounds */ #if 1 diff --git a/src/target/etb.c b/src/target/etb.c index bc0e1bf2c7..3113eca065 100644 --- a/src/target/etb.c +++ b/src/target/etb.c @@ -21,7 +21,7 @@ #include "config.h" #endif -#include "armv4_5.h" +#include "arm.h" #include "etm.h" #include "etb.h" #include "register.h" diff --git a/src/target/etm.c b/src/target/etm.c index b45fcf507a..3aace81ecd 100644 --- a/src/target/etm.c +++ b/src/target/etm.c @@ -21,7 +21,7 @@ #include "config.h" #endif -#include "armv4_5.h" +#include "arm.h" #include "etm.h" #include "etb.h" #include "image.h" diff --git a/src/target/etm_dummy.c b/src/target/etm_dummy.c index 647774f24d..19a078f13c 100644 --- a/src/target/etm_dummy.c +++ b/src/target/etm_dummy.c @@ -21,7 +21,7 @@ #include "config.h" #endif -#include "armv4_5.h" +#include "arm.h" #include "etm_dummy.h" diff --git a/src/target/oocd_trace.c b/src/target/oocd_trace.c index ac79f18d98..ae3a5dff76 100644 --- a/src/target/oocd_trace.c +++ b/src/target/oocd_trace.c @@ -21,7 +21,7 @@ #include "config.h" #endif -#include "armv4_5.h" +#include "arm.h" #include "oocd_trace.h" /* diff --git a/src/target/xscale.c b/src/target/xscale.c index 816579ad8e..61994dcb7b 100644 --- a/src/target/xscale.c +++ b/src/target/xscale.c @@ -37,6 +37,7 @@ #include "register.h" #include "image.h" #include "arm_opcodes.h" +#include "armv4_5.h" /* diff --git a/src/target/xscale.h b/src/target/xscale.h index 43edeecd0c..97038d8c6e 100644 --- a/src/target/xscale.h +++ b/src/target/xscale.h @@ -23,7 +23,7 @@ #ifndef XSCALE_H #define XSCALE_H -#include +#include #include #include