From: Stefan Mahr <stefan.mahr@sphairon.com>
Date: Wed, 27 Jun 2012 22:53:54 +0000 (+0200)
Subject: jtag: fix opendous reset command
X-Git-Tag: v0.6.0-rc1~38
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=07251ab8d81b2b5491af673b694bebbbc574c112

jtag: fix opendous reset command

This cast to uint16_t is not (host) endianess save.
Depending on compiler usb_out_buffer[1] may be undefined.

Change-Id: If686e5d5da39541329c340bbdef472ee7ab0281c
Signed-off-by: Stefan Mahr <stefan.mahr@sphairon.com>
Reviewed-on: http://openocd.zylin.com/732
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
---

diff --git a/src/jtag/drivers/opendous.c b/src/jtag/drivers/opendous.c
index 0bb6da66f3..1b74bd5a49 100644
--- a/src/jtag/drivers/opendous.c
+++ b/src/jtag/drivers/opendous.c
@@ -465,7 +465,8 @@ void opendous_simple_command(uint8_t command, uint8_t _data)
 
 	DEBUG_JTAG_IO("0x%02x 0x%02x", command, _data);
 
-	usb_out_buffer[0] = (uint16_t) 2;
+	usb_out_buffer[0] = 2;
+	usb_out_buffer[1] = 0;
 	usb_out_buffer[2] = command;
 	usb_out_buffer[3] = _data;