command: initialize the command mode for every command 61/4861/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 19 Jan 2019 23:52:07 +0000 (00:52 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Sun, 27 Jan 2019 11:45:01 +0000 (11:45 +0000)
All the commands in OpenOCD have been inspected and have the
command mode initialize, apart for two of them.
This is not critical, because the uninitialized value (0) is
equivalent to the enum COMMAND_EXEC, that is also the correct
value for the two mentioned commands.

To keep the code consistent, initialize the command mode to
COMMAND_EXEC.

Change-Id: Iaf043364cbd1005418d787ed045a3ec653612382
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4861
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/flash/nand/mxc.c
src/target/armv4_5.c

index 5e59b9a..6be4160 100644 (file)
@@ -179,6 +179,7 @@ COMMAND_HANDLER(handle_mxc_biswap_command)
 static const struct command_registration mxc_sub_command_handlers[] = {
        {
                .name = "biswap",
+               .mode = COMMAND_EXEC,
                .handler = handle_mxc_biswap_command,
                .help = "Turns on/off bad block information swaping from main area, "
                        "without parameter query status.",
index af8fd9a..b3bee8d 100644 (file)
@@ -1134,6 +1134,7 @@ static const struct command_registration arm_exec_command_handlers[] = {
        },
        {
                .name = "mrc",
+               .mode = COMMAND_EXEC,
                .jim_handler = &jim_mcrmrc,
                .help = "read coprocessor register",
                .usage = "cpnum op1 CRn CRm op2",