- Do not specify -e twice.
- Use "which" instead of calling commands that might not exist.
- Fix bashism ("==" is C not sh)
- Carefully quote potentially empty variables
- Check command arguments before doing anything
- Rewrite argument checking to be more easily extensible
- Consistent indentation
- UNIX style error messages
# Run the autotools bootstrap sequence to create the configure script
# Run the autotools bootstrap sequence to create the configure script
-# Stop execution as soon as we have an unknown command
+# Abort execution on error
-if libtoolize --version >/dev/null 2>&1; then
- libtoolize="libtoolize"
-elif glibtoolize --version >/dev/null 2>&1; then
- libtoolize="glibtoolize"
+if which libtoolize > /dev/null; then
+ libtoolize="libtoolize"
+elif which glibtoolize >/dev/null; then
+ libtoolize="glibtoolize"
- echo "libtool is required" >&2
- exit 1
+ echo "$0: Error: libtool is required" >&2
+ exit 1
+fi
+
+if [ "$1" = "nosubmodule" ]; then
+ SKIP_SUBMODULE=1
+elif [ -n "$1" ]; then
+ echo "$0: Illegal argument $1"
+ echo "USAGE: $0 [nosubmodule]"
+ exit 1
fi
# bootstrap the autotools
fi
# bootstrap the autotools
# current source snapshots (working from GIT, or some source snapshot, etc)
# otherwise the documentation will fail to build due to missing version.texi
# current source snapshots (working from GIT, or some source snapshot, etc)
# otherwise the documentation will fail to build due to missing version.texi
-if [ $1 == nosubmodule ]; then
+if [ -n "$SKIP_SUBMODULE" ]; then
echo "Skipping submodule setup"
echo "Skipping submodule setup"
echo "Setting up submodules"
git submodule init
git submodule update
echo "Setting up submodules"
git submodule init
git submodule update
-else
- echo "Argument to bootstrap is either no argument or nosubmodule"
- exit 1
-echo "Bootstrap complete. Quick start build instructions:"
+echo "Bootstrap complete. Quick build instructions:"
echo "./configure --enable-maintainer-mode ...."
echo "./configure --enable-maintainer-mode ...."
Linking to existing account procedure
If you already have an account and want to add another login method
you
MUST first sign in with your existing account and
then change URL to read
https://review.openocd.org/login/?link
to get to this page again but this time it'll work for linking. Thank you.
SSH host keys fingerprints
1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=.. |
|+o.. . |
|*.o . . |
|+B . . . |
|Bo. = o S |
|Oo.+ + = |
|oB=.* = . o |
| =+=.+ + E |
|. .=o . o |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)