more in_handler typo fixes
authoroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Thu, 7 May 2009 23:00:28 +0000 (23:00 +0000)
committeroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Thu, 7 May 2009 23:00:28 +0000 (23:00 +0000)
git-svn-id: svn://svn.berlios.de/openocd/trunk@1657 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/target/arm7tdmi.c
src/target/arm9tdmi.c

index aac1fef6aced2e266700c74307c1c2f02423380a..5f45ad9977e52ac0346bbfeaf51e4eedaf212133 100644 (file)
@@ -234,9 +234,11 @@ int arm7tdmi_clock_data_in(arm_jtag_t *jtag_info, u32 *in)
        return ERROR_OK;
 }
 
-void arm_endianness(u8 *tmp, void *in, int size, int be)
+void arm_endianness(u8 *tmp, void *in, int size, int be, int flip)
 {
-       u32 readback=flip_u32(le_to_h_u32(tmp), 32);
+       u32 readback=le_to_h_u32(tmp);
+       if (flip)
+               readback=flip_u32(readback, 32);
        switch (size)
        {
                case 4:
@@ -295,7 +297,7 @@ int arm7tdmi_clock_data_in_endianness(arm_jtag_t *jtag_info, void *in, int size,
 
        jtag_add_dr_scan_now(2, fields, TAP_INVALID);
 
-       arm_endianness(tmp, in, size, be);
+       arm_endianness(tmp, in, size, be, 1);
 
        jtag_add_runtest(0, TAP_INVALID);
 
index 73f0879fa477fcb09e2b2cb0bde4b5e73045f55e..57dab4fa85d49be6091e9a9b8e1c3ccff7f564ea 100644 (file)
@@ -238,7 +238,7 @@ int arm9tdmi_clock_out(arm_jtag_t *jtag_info, u32 instr, u32 out, u32 *in, int s
                fields[0].in_value=tmp;
                jtag_add_dr_scan_now(3, fields, TAP_INVALID);
 
-               *in=flip_u32(le_to_h_u32(tmp), 32);
+               *in=le_to_h_u32(tmp);
        }
        else
        {
@@ -301,7 +301,7 @@ int arm9tdmi_clock_data_in(arm_jtag_t *jtag_info, u32 *in)
 
        jtag_add_dr_scan_now(3, fields, TAP_INVALID);
 
-       *in=flip_u32(le_to_h_u32(tmp), 32);
+       *in=le_to_h_u32(tmp);
 
        jtag_add_runtest(0, TAP_INVALID);
 
@@ -326,7 +326,7 @@ int arm9tdmi_clock_data_in(arm_jtag_t *jtag_info, u32 *in)
        return ERROR_OK;
 }
 
-extern void arm_endianness(u8 *tmp, void *in, int size, int be);
+extern void arm_endianness(u8 *tmp, void *in, int size, int be, int flip);
 
 /* clock the target, and read the databus
  * the *in pointer points to a buffer where elements of 'size' bytes
@@ -366,7 +366,7 @@ int arm9tdmi_clock_data_in_endianness(arm_jtag_t *jtag_info, void *in, int size,
 
        jtag_add_dr_scan_now(3, fields, TAP_INVALID);
 
-       arm_endianness(tmp, in, size, be);
+       arm_endianness(tmp, in, size, be, 0);
 
 
        jtag_add_runtest(0, TAP_INVALID);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)