coding style: fix multi-line dereferencing 29/5629/4
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 6 May 2019 17:31:00 +0000 (19:31 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 6 Jun 2020 17:06:05 +0000 (18:06 +0100)
Issue identified by checkpatch script from Linux kernel v5.1 using
the command

find src/ -type f -exec ./tools/scripts/checkpatch.pl \
-q --types MULTILINE_DEREFERENCE -f {} \;

Change-Id: Icba05613e22a72ecc3e6a0aad7cb6b479496146f
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5629
Tested-by: jenkins
Reviewed-by: Marc Schink <dev@zapb.de>
src/rtos/linux.c
src/target/etm.c

index e85a3bdf8d0899a9287ecff862e890e5ed5848b1..63659bb05bbab57217544afae3e7462a286d4cdc 100644 (file)
@@ -995,10 +995,8 @@ static int linux_task_update(struct target *target, int context)
                                        if (context)
                                                thread_list->context =
                                                        cpu_context_read(target,
-                                                               thread_list->
-                                                               base_addr,
-                                                               &thread_list->
-                                                               thread_info_addr);
+                                                               thread_list->base_addr,
+                                                               &thread_list->thread_info_addr);
                                } else {
                                        /*  it is a current thread no need to read context */
                                }
@@ -1190,9 +1188,8 @@ int linux_gdb_T_packet(struct connection *connection,
                                } else {
                                        /* delete item in the list   */
                                        linux_os->thread_list =
-                                               liste_del_task(linux_os->
-                                                       thread_list, &temp,
-                                                       prev);
+                                               liste_del_task(linux_os->thread_list,
+                                                       &temp, prev);
                                        linux_os->thread_count--;
                                        gdb_put_packet(connection, "E01", 3);
                                        return ERROR_OK;
@@ -1323,9 +1320,7 @@ static int linux_thread_packet(struct connection *connection, char const *packet
                        if (strncmp(packet, "qSymbol", 7) == 0) {
                                if (rtos_qsymbol(connection, packet, packet_size) == 1) {
                                        linux_compute_virt2phys(target,
-                                                       target->rtos->
-                                                       symbols[INIT_TASK].
-                                                       address);
+                                                       target->rtos->symbols[INIT_TASK].address);
                                }
 
                                break;
@@ -1376,8 +1371,7 @@ static int linux_thread_packet(struct connection *connection, char const *packet
                                }
 
                                if ((ct != NULL) && (ct->threadid !=
-                                                target->rtos->
-                                                current_threadid)
+                                                target->rtos->current_threadid)
                                && (target->rtos->current_threadid != -1))
                                        LOG_WARNING("WARNING! current GDB thread do not match "
                                                        "current thread running. "
@@ -1410,8 +1404,7 @@ static int linux_os_smp_init(struct target *target)
        while (head != (struct target_list *)NULL) {
                if (head->target->rtos != rtos) {
                        struct linux_os *smp_os_linux =
-                               (struct linux_os *)head->target->rtos->
-                               rtos_specific_params;
+                               (struct linux_os *)head->target->rtos->rtos_specific_params;
                        /*  remap smp target on rtos  */
                        free(head->target->rtos);
                        head->target->rtos = rtos;
index 5218a9e480bfb19f0fac9998c7ff2a46e56dc940..5d079ffa8285360f78ab990491db6de9f9cce1cc 100644 (file)
@@ -1074,8 +1074,8 @@ static int etmv1_analyze_trace(struct etm_context *ctx, struct command_invocatio
                                        (instruction.type == ARM_STM)) {
                                        int i;
                                        for (i = 0; i < 16; i++) {
-                                               if (instruction.info.load_store_multiple.
-                                                       register_list & (1 << i)) {
+                                               if (instruction.info.load_store_multiple.register_list
+                                                       & (1 << i)) {
                                                        uint32_t data;
                                                        if (etmv1_data(ctx, 4, &data) != 0)
                                                                return ERROR_ETM_ANALYSIS_FAILED;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)