bitq: reduce scope of variables
authorAndreas Fritiofson <andreas.fritiofson@gmail.com>
Tue, 15 Nov 2011 23:14:37 +0000 (00:14 +0100)
committerSpencer Oliver <spen@spen-soft.co.uk>
Wed, 16 Nov 2011 23:47:23 +0000 (23:47 +0000)
Change-Id: Ie1049b9d8ed5e44aee038e9181e423c35b4263c4
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/208
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/jtag/drivers/bitq.c

index 064f43b01146696f9e274e8d00a22efb7db3c6eb..db16757c85fa4df4f3613fd05e2a3b2e8c6a3f52 100644 (file)
@@ -43,9 +43,6 @@ static struct bitq_state bitq_in_state;
  */
 void bitq_in_proc(void)
 {
  */
 void bitq_in_proc(void)
 {
-       struct scan_field* field;
-       int           tdo;
-
        /* loop through the queue */
        while (bitq_in_state.cmd)
        {
        /* loop through the queue */
        while (bitq_in_state.cmd)
        {
@@ -55,6 +52,7 @@ void bitq_in_proc(void)
                        /* loop through the fields */
                        while (bitq_in_state.field_idx < bitq_in_state.cmd->cmd.scan->num_fields)
                        {
                        /* loop through the fields */
                        while (bitq_in_state.field_idx < bitq_in_state.cmd->cmd.scan->num_fields)
                        {
+                               struct scan_field *field;
                                field = &bitq_in_state.cmd->cmd.scan->fields[bitq_in_state.field_idx];
                                if (field->in_value)
                                {
                                field = &bitq_in_state.cmd->cmd.scan->fields[bitq_in_state.field_idx];
                                if (field->in_value)
                                {
@@ -66,7 +64,8 @@ void bitq_in_proc(void)
                                                /* mask of next bit to be scanned */
                                                uint8_t in_mask = 1 << (bitq_in_state.bit_pos % 8);
 
                                                /* mask of next bit to be scanned */
                                                uint8_t in_mask = 1 << (bitq_in_state.bit_pos % 8);
 
-                                               if ((tdo = bitq_interface->in()) < 0)
+                                               int tdo = bitq_interface->in();
+                                               if (tdo < 0)
                                                {
 #ifdef _DEBUG_JTAG_IO_
                                                        LOG_DEBUG("bitq in EOF");
                                                {
 #ifdef _DEBUG_JTAG_IO_
                                                        LOG_DEBUG("bitq in EOF");

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)