hello: use register_commands()
authorZachary T Welch <zw@superlucidity.net>
Sat, 21 Nov 2009 21:49:00 +0000 (13:49 -0800)
committerZachary T Welch <zw@superlucidity.net>
Wed, 25 Nov 2009 05:37:32 +0000 (21:37 -0800)
Use new register_commands() with command registration table.

src/hello.c

index 8c97a401e85f34ef5025bf314f0934f5c7430998..6f0249487fd94ff5cffadeb831e48b08293d1727 100644 (file)
@@ -53,24 +53,36 @@ COMMAND_HANDLER(handle_flag_command)
                        &foo_flag, "foo flag");
 }
 
+static const struct command_registration foo_command_handlers[] = {
+       {
+               .name = "bar",
+               .handler = &handle_foo_command,
+               .mode = COMMAND_ANY,
+               .help = "<address> [enable|disable] - an example command",
+       },
+       {
+               .name = "baz",
+               .handler = &handle_foo_command,
+               .mode = COMMAND_ANY,
+               .help = "<address> [enable|disable] - a sample command",
+       },
+       {
+               .name = "flag",
+               .handler = &handle_flag_command,
+               .mode = COMMAND_ANY,
+               .help = "[on|off] - set a flag",
+       },
+       COMMAND_REGISTRATION_DONE
+};
+
 int foo_register_commands(struct command_context *cmd_ctx)
 {
        // register several commands under the foo command
        struct command *cmd = COMMAND_REGISTER(cmd_ctx, NULL, "foo",
-                       NULL, COMMAND_ANY, "foo: command handler skeleton");
+                       NULL, COMMAND_ANY, "example command handler skeleton");
 
-       COMMAND_REGISTER(cmd_ctx, cmd, "bar",
-                       &handle_foo_command, COMMAND_ANY,
-                       "<address> [enable|disable] - an example command");
-       COMMAND_REGISTER(cmd_ctx, cmd, "baz",
-                       &handle_foo_command, COMMAND_ANY,
-                       "<address> [enable|disable] - a sample command");
 
-       COMMAND_REGISTER(cmd_ctx, cmd, "flag",
-                       &handle_flag_command, COMMAND_ANY,
-                       "[on|off] - set a flag");
-
-       return ERROR_OK;
+       return register_commands(cmd_ctx, cmd, foo_command_handlers);
 }
 
 static COMMAND_HELPER(handle_hello_args, const char **sep, const char **name)
@@ -99,12 +111,20 @@ COMMAND_HANDLER(handle_hello_command)
        return retval;
 }
 
+static const struct command_registration hello_command_handlers[] = {
+       {
+               .name = "hello",
+               .handler = &handle_hello_command,
+               .mode = COMMAND_ANY,
+               .help = "prints a warm welcome",
+               .usage = "[<name>]",
+       },
+       COMMAND_REGISTRATION_DONE
+};
+
 int hello_register_commands(struct command_context *cmd_ctx)
 {
        foo_register_commands(cmd_ctx);
 
-       struct command *cmd = COMMAND_REGISTER(cmd_ctx, NULL, "hello",
-                       &handle_hello_command, COMMAND_ANY,
-                       "[<name>] - prints a warm welcome");
-       return cmd ? ERROR_OK : -ENOMEM;
+       return register_commands(cmd_ctx, NULL, hello_command_handlers);
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)