script_debug(): improve types
authorZachary T Welch <zw@superlucidity.net>
Mon, 9 Nov 2009 14:07:21 +0000 (06:07 -0800)
committerZachary T Welch <zw@superlucidity.net>
Wed, 11 Nov 2009 13:40:48 +0000 (05:40 -0800)
Use unsigned type for number of arguments.

src/helper/command.c
src/helper/command.h

index 2b8f646b9c1716d665d5ebdeab156c127b2fd216..c6327029217ab0506dcd22bba8cc97d2df5f1911 100644 (file)
@@ -59,12 +59,12 @@ static void tcl_output(void *privData, const char *file, unsigned line,
 
 extern command_context_t *global_cmd_ctx;
 
-void script_debug(Jim_Interp *interp, const char *name, int argc, Jim_Obj *const *argv)
+void script_debug(Jim_Interp *interp, const char *name,
+               unsigned argc, Jim_Obj *const *argv)
 {
-       int i;
-
        LOG_DEBUG("command - %s", name);
-       for (i = 0; i < argc; i++) {
+       for (unsigned i = 0; i < argc; i++)
+       {
                int len;
                const char *w = Jim_GetString(argv[i], &len);
 
index 70b00c3292de41b8b7bd3152e348227a6bc528e6..0b86b881e4d056f08fc0a69dd7db1f6f6975f469 100644 (file)
@@ -170,6 +170,7 @@ DECLARE_PARSE_WRAPPER(_s8, int8_t);
                } \
        } while (0)
 
-void script_debug(Jim_Interp *interp, const char *cmd, int argc, Jim_Obj *const *argv);
+void script_debug(Jim_Interp *interp, const char *cmd,
+               unsigned argc, Jim_Obj *const *argv);
 
 #endif /* COMMAND_H */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)