add command_handler_t type
authorZachary T Welch <zw@superlucidity.net>
Wed, 11 Nov 2009 03:00:01 +0000 (19:00 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 18:51:45 +0000 (10:51 -0800)
This patch adds new typedefs for command handler callback functions.
Users of this type signature were updated to use these new types.
It uses the new __COMMAND_HANDLER macro to prevent duplication.

src/helper/command.c
src/helper/command.h

index 603da82f65c67cc80f82f5c615b36e05cd12ea61..e467be0b2d36ad54565fea51a2f0a5f6e19dd131 100644 (file)
@@ -225,9 +225,7 @@ static void command_add_child(struct command_s **head, struct command_s *c)
 }
 
 command_t* register_command(command_context_t *context,
-               command_t *parent, char *name,
-               int (*handler)(struct command_context_s *context,
-                               char* name, char** args, int argc),
+               command_t *parent, char *name, command_handler_t handler,
                enum command_mode mode, char *help)
 {
        if (!context || !name)
index 236dabbe85c202f6034ed3fb4517d5dd3558c5fc..aec066d088faea35071dad9ea8aac77624ba8ba7 100644 (file)
@@ -122,12 +122,15 @@ typedef struct command_context_s
 #define COMMAND_HELPER(name, extra...) __COMMAND_HANDLER(name, extra)
 
 
+/// The type signature for commands' handler functions.
+typedef __COMMAND_HANDLER((*command_handler_t));
+
 typedef struct command_s
 {
        char *name;
        struct command_s *parent;
        struct command_s *children;
-       int (*handler)(struct command_context_s *context, char* name, char** args, int argc);
+       command_handler_t handler;
        enum command_mode mode;
        struct command_s *next;
 } command_t;
@@ -143,9 +146,7 @@ typedef struct command_s
 char *command_name(struct command_s *c, char delim);
 
 command_t* register_command(command_context_t *context,
-               command_t *parent, char *name,
-               int (*handler)(struct command_context_s *context,
-                               char* name, char** args, int argc),
+               command_t *parent, char *name, command_handler_t handler,
                enum command_mode mode, char *help);
 
 int unregister_command(command_context_t *context, char *name);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)