cortex: Set default memaccess_tck only during examine 55/3155/3
authorAndreas Fritiofson <andreas.fritiofson@gmail.com>
Sun, 6 Dec 2015 15:58:13 +0000 (16:58 +0100)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Tue, 29 Dec 2015 20:31:55 +0000 (20:31 +0000)
It's currently set during target creation but the AP that will be used
for the target is not even known.

Change-Id: I4502e7eb1fa8d90f746445b8cf8a4c21cb7d519e
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/3155
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
src/target/cortex_a.c
src/target/cortex_m.c

index 11558b9a6988d6b225869e9126c2d367cc4d37ee..5e3a1a4b9a2dc6d2d8f275152e1a1a608c2d4b20 100644 (file)
@@ -2929,6 +2929,8 @@ static int cortex_a_examine_first(struct target *target)
                return retval;
        }
 
+       armv7a->debug_ap->memaccess_tck = 80;
+
        /* Search for the AHB-AB.
         * REVISIT: We should search for AXI-AP as well and make sure the AP's MEMTYPE says it
         * can access system memory. */
@@ -3117,7 +3119,6 @@ static int cortex_a_init_arch_info(struct target *target,
                tap->dap->tap = tap;
        }
 
-       tap->dap->ap[dap_ap_get_select(tap->dap)].memaccess_tck = 80;
        armv7a->arm.dap = tap->dap;
 
        cortex_a->fast_reg_read = 0;
index b813bd7e01b9be05f3f8a13b8db12a409951a71c..d539a8241667c9e55f18e6524b4795e8d3a8cca3 100644 (file)
@@ -2122,9 +2122,6 @@ static int cortex_m_init_arch_info(struct target *target,
 
        armv7m->arm.dap = tap->dap;
 
-       /* Leave (only) generic DAP stuff for debugport_init(); */
-       tap->dap->ap[dap_ap_get_select(tap->dap)].memaccess_tck = 8;
-
        /* register arch-specific functions */
        armv7m->examine_debug_reason = cortex_m_examine_debug_reason;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)