helper/command: return proper JIM error code 73/4973/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Tue, 26 Feb 2019 08:32:04 +0000 (09:32 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Wed, 6 Mar 2019 15:38:07 +0000 (15:38 +0000)
The function command_unknown() is expected to return a value
recognized as JIM error code, as it is correctly done in the
other cases it returns.

Fix the only case in which command_unknown() does not return
a JIM error code, by s/ERROR_FAIL/JIM_ERR/

Change-Id: Ib98b75755ae36870bd68c17f8839ddbfa06c6312
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4973
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/helper/command.c

index 0afbe2c..7a3c2d4 100644 (file)
@@ -1037,7 +1037,7 @@ static int command_unknown(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
        /* pass the command through to the intended handler */
        if (c->jim_handler) {
                if (!command_can_run(cmd_ctx, c))
-                       return ERROR_FAIL;
+                       return JIM_ERR;
 
                interp->cmdPrivData = c->jim_handler_data;
                return (*c->jim_handler)(interp, count, start);