target/arm_cti: add debug message when an incorrect CTI register name is used 16/4816/2
authorTarek BOCHKATI <tarek.bouchkati@gmail.com>
Thu, 20 Dec 2018 18:33:26 +0000 (19:33 +0100)
committerMatthias Welwarsky <matthias@welwarsky.de>
Thu, 27 Dec 2018 12:47:35 +0000 (12:47 +0000)
the patch also contains some typo fixes

Change-Id: Ia4267036068455144cdcbfdffed15518d48f445e
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/4816
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/arm_cti.c

index dcaf21e50a7550dce8e90a09a66c2c3d1806bab3..df60372533112c01bbb72fc2799ac2cf49a08eca 100644 (file)
@@ -216,6 +216,8 @@ static int cti_find_reg_offset(const char *name)
                if (!strcmp(name, cti_names[i].label))
                        return cti_names[i].offset;
        }
                if (!strcmp(name, cti_names[i].label))
                        return cti_names[i].offset;
        }
+
+       LOG_ERROR("unknown CTI register %s", name);
        return -1;
 }
 
        return -1;
 }
 
@@ -297,7 +299,7 @@ COMMAND_HANDLER(handle_cti_write)
        uint32_t value;
 
        if (CMD_ARGC != 2) {
        uint32_t value;
 
        if (CMD_ARGC != 2) {
-               Jim_SetResultString(interp, "Wrong numer of args", -1);
+               Jim_SetResultString(interp, "Wrong number of args", -1);
                return ERROR_FAIL;
        }
 
                return ERROR_FAIL;
        }
 
@@ -320,7 +322,7 @@ COMMAND_HANDLER(handle_cti_read)
        uint32_t value;
 
        if (CMD_ARGC != 1) {
        uint32_t value;
 
        if (CMD_ARGC != 1) {
-               Jim_SetResultString(interp, "Wrong numer of args", -1);
+               Jim_SetResultString(interp, "Wrong number of args", -1);
                return ERROR_FAIL;
        }
 
                return ERROR_FAIL;
        }
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)