remove rlink structure typedefs
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 20:19:39 +0000 (12:19 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 20:19:39 +0000 (12:19 -0800)
Remove useless typedefs from the rlink driver.  Improve whitespace.

src/jtag/rlink/rlink.c
src/jtag/rlink/rlink.h
src/jtag/rlink/rlink_speed_table.c

index bc354575b67b89af54d8d1f6cc3bda441f9c96e6..9dd8b888ad96bbab09ecc4f256ebeb3bb036692a 100644 (file)
@@ -576,8 +576,7 @@ dtc_run_download(
  * The dtc reply queue is a singly linked list that describes what to do with the reply packet that comes from the DTC.  Only SCAN_IN and SCAN_IO generate these entries.
  */
 
-typedef
-struct dtc_reply_queue_entry_s {
+struct dtc_reply_queue_entry {
        struct dtc_reply_queue_entry_s  *next;
        jtag_command_t  *cmd;   /* the command that resulted in this entry */
 
@@ -588,7 +587,7 @@ struct dtc_reply_queue_entry_s {
                int             length;         /* how many bits are processed in this operation? */
                enum scan_type  type;           /* SCAN_IN/SCAN_OUT/SCAN_IO */
        } scan;
-} dtc_reply_queue_entry_t;
+};
 
 
 /*
@@ -598,8 +597,8 @@ struct dtc_reply_queue_entry_s {
 
 static
 struct {
-       dtc_reply_queue_entry_t *rq_head;
-       dtc_reply_queue_entry_t *rq_tail;
+       struct dtc_reply_queue_entry    *rq_head;
+       struct dtc_reply_queue_entry    *rq_tail;
        uint32_t                        cmd_index;
        uint32_t                        reply_index;
        uint8_t                 cmd_buffer[USB_EP2BANK_SIZE];
@@ -631,7 +630,7 @@ dtc_queue_init(void) {
 
 static
 inline
-dtc_reply_queue_entry_t *
+struct dtc_reply_queue_entry *
 dtc_queue_enqueue_reply(
        enum scan_type  type,
        uint8_t                         *buffer,
@@ -640,9 +639,9 @@ dtc_queue_enqueue_reply(
        int                             length,
        jtag_command_t  *cmd
 ) {
-       dtc_reply_queue_entry_t *rq_entry;
+       struct dtc_reply_queue_entry    *rq_entry;
 
-       rq_entry = malloc(sizeof(dtc_reply_queue_entry_t));
+       rq_entry = malloc(sizeof(struct dtc_reply_queue_entry));
        if (rq_entry != NULL) {
                rq_entry->scan.type = type;
                rq_entry->scan.buffer = buffer;
@@ -672,7 +671,7 @@ dtc_queue_enqueue_reply(
 static
 int
 dtc_queue_run(void) {
-       dtc_reply_queue_entry_t *rq_p, *rq_next;
+       struct dtc_reply_queue_entry    *rq_p, *rq_next;
        int                     retval;
        int                     usb_err;
        int                     bit_cnt;
index 6bab26e6cb2c4f8f3732923fd9953951178ee840..b53be5ceb62c68421fffea9d21811695d82d8c44 100644 (file)
 
 #include "types.h"
 
-typedef
-struct rlink_speed_table_s {
-       uint8_t const   *dtc;
-       uint16_t                        dtc_size;
-       uint16_t                        khz;
-       uint8_t                 prescaler;
-} rlink_speed_table_t;
+struct rlink_speed_table {
+       uint8_t const *dtc;
+       uint16_t dtc_size;
+       uint16_t khz;
+       uint8_t prescaler;
+};
 
-extern const rlink_speed_table_t       rlink_speed_table[];
-extern const size_t                                    rlink_speed_table_size;
+extern const struct rlink_speed_table rlink_speed_table[];
+extern const size_t rlink_speed_table_size;
index 1f3e973b1caad8d42fecbdcd99e08aba56e61b26..5c40ab465a855bfea94a7fac2a56968074462a3e 100644 (file)
@@ -87,7 +87,7 @@ static const uint8_t dtc_2[] = {
        36, 139, 112, 193, 151, 96
 };
 
-const rlink_speed_table_t rlink_speed_table[] = {{
+const struct rlink_speed_table rlink_speed_table[] = {{
        dtc_64, sizeof(dtc_64), (ST7_FOSC * 2) / (1000 * 64), 64
 }, {
        dtc_11, sizeof(dtc_11), (ST7_FOSC * 2) / (1000 * 11), 11

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)