target_request: replace command_print() with command_output_text() 51/5051/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Wed, 3 Apr 2019 08:14:29 +0000 (10:14 +0200)
committerTomas Vanek <vanekt@fbl.cz>
Tue, 14 May 2019 18:33:34 +0000 (19:33 +0100)
To prepare for handling TCL return values consistently, all calls
to command_print/command_print_sameline should be ready to switch
to CMD as first parameter.

When dumping traces or semihosting text, the command that enabled
it is already completed, so CMD is not a valid value.
Plus, we want the dump to be printed in the command context where
the enable command was executed.

Replace command_print() with command_output_text().

Change-Id: I297a2b799a914233499641062407cf6e8b9fe012
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5051
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/target/target_request.c

index 6ca204b508dd71e04a1be7abcb545d12597dbb5c..2df29587fc125fa7aa8b29e0b8c35a02f70b7a00 100644 (file)
@@ -56,7 +56,7 @@ static int target_asciimsg(struct target *target, uint32_t length)
        LOG_DEBUG("%s", msg);
 
        while (c) {
        LOG_DEBUG("%s", msg);
 
        while (c) {
-               command_print(c->cmd_ctx, "%s", msg);
+               command_output_text(c->cmd_ctx, msg);
                c = c->next;
        }
 
                c = c->next;
        }
 
@@ -100,7 +100,7 @@ static int target_hexmsg(struct target *target, int size, uint32_t length)
                        LOG_DEBUG("%s", line);
 
                        while (c) {
                        LOG_DEBUG("%s", line);
 
                        while (c) {
-                               command_print(c->cmd_ctx, "%s", line);
+                               command_output_text(c->cmd_ctx, line);
                                c = c->next;
                        }
                        c = target->dbgmsg;
                                c = c->next;
                        }
                        c = target->dbgmsg;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)