Revert "adapter: expose HLA interface in struct adapter_driver" 33/5533/6
authorAntonio Borneo <borneo.antonio@gmail.com>
Thu, 19 Mar 2020 11:12:20 +0000 (12:12 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sun, 24 May 2020 20:34:05 +0000 (21:34 +0100)
No reason to keep longer this temporary hack.
Remove it by reverting the original commit.

Change-Id: I5c6dcdb1f4755b7dba4c03a5033913ef8db35e18
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5533
Tested-by: jenkins
src/jtag/hla/hla_interface.c
src/jtag/interface.h

index 064c268e4170e9b2c7c47eea48d8d9fc2cd43105..6d5cdc5e7018f3527385808ec585da4a571d1931 100644 (file)
@@ -361,7 +361,4 @@ struct adapter_driver hl_adapter_driver = {
        .poll_trace = &hl_interface_poll_trace,
 
        /* no ops for HLA, targets hla_target and stm8 intercept them all */
-
-       /* FIXME: helper to simplify transition of HLA drivers. To be removed */
-       .hla_if = &hl_if,
 };
index a471aa96dfd311744b642b86efe8ff09c5f8b4b3..42598c1ae8fc558012f9f3fbec325deb89ad1da3 100644 (file)
@@ -38,9 +38,6 @@
  */
 
 
-/* FIXME: prototype to simplify transition of HLA drivers. To be removed */
-struct hl_interface_s;
-
 /** implementation of wrapper function tap_set_state() */
 void tap_set_state_impl(tap_state_t new_state);
 
@@ -366,9 +363,6 @@ struct adapter_driver {
 
        /* SWIM APIs */
        const struct swim_driver *swim_ops;
-
-       /* FIXME: helper to simplify transition of HLA drivers. To be removed */
-       struct hl_interface_s *hla_if;
 };
 
 extern const char * const jtag_only[];

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)