reg_arch_type_t -> struct reg_arch_type
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 16:44:18 +0000 (08:44 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 19:58:12 +0000 (11:58 -0800)
Remove misleading typedef and redundant suffix from struct reg_arch_type.

src/server/gdb_server.c
src/target/register.c
src/target/register.h
src/target/target.c

index 389710eb61502de7519176f32ffca611261a1f92..0bdb3a0c2154b0fde9da720f0e815b7d4f9b7a23 100644 (file)
@@ -1003,7 +1003,7 @@ int gdb_set_registers_packet(struct connection *connection, target_t *target, ch
                        LOG_ERROR("BUG: register packet is too small for registers");
                }
 
-               reg_arch_type_t *arch_type;
+               struct reg_arch_type *arch_type;
                bin_buf = malloc(CEIL(reg_list[i]->size, 8));
                gdb_target_to_reg(target, packet_p, chars, bin_buf);
 
@@ -1070,7 +1070,7 @@ int gdb_set_register_packet(struct connection *connection, target_t *target, cha
        reg_t **reg_list;
        int reg_list_size;
        int retval;
-       reg_arch_type_t *arch_type;
+       struct reg_arch_type *arch_type;
 
        LOG_DEBUG("-");
 
index 2efcd5f8bb8f8e1a5a490e7c8a4ce34a8bce7d70..c3ad830a55151f123e3eb6183dc9098333c6d0fe 100644 (file)
@@ -28,7 +28,7 @@
 #include "log.h"
 
 
-reg_arch_type_t *reg_arch_types = NULL;
+struct reg_arch_type *reg_arch_types = NULL;
 
 reg_t* register_get_by_name(struct reg_cache *first,
                const char *name, bool search_all)
@@ -68,7 +68,7 @@ struct reg_cache** register_get_last_cache_p(struct reg_cache **first)
 
 int register_reg_arch_type(int (*get)(reg_t *reg), int (*set)(reg_t *reg, uint8_t *buf))
 {
-       reg_arch_type_t** arch_type_p = &reg_arch_types;
+       struct reg_arch_type** arch_type_p = &reg_arch_types;
        int id = 0;
 
        if (*arch_type_p)
@@ -80,7 +80,7 @@ int register_reg_arch_type(int (*get)(reg_t *reg), int (*set)(reg_t *reg, uint8_
                }
        }
 
-       (*arch_type_p) = malloc(sizeof(reg_arch_type_t));
+       (*arch_type_p) = malloc(sizeof(struct reg_arch_type));
        (*arch_type_p)->id = id + 1;
        (*arch_type_p)->set = set;
        (*arch_type_p)->get = get;
@@ -89,9 +89,9 @@ int register_reg_arch_type(int (*get)(reg_t *reg), int (*set)(reg_t *reg, uint8_
        return id + 1;
 }
 
-reg_arch_type_t* register_get_arch_type(int id)
+struct reg_arch_type* register_get_arch_type(int id)
 {
-       reg_arch_type_t *arch_type = reg_arch_types;
+       struct reg_arch_type *arch_type = reg_arch_types;
 
        while (arch_type)
        {
index 422fbd29318b5f0c8fdb67f9b085c94e3f1c6f33..57342ba395d1322bbf80dc8fe584eb7c6de82b30 100644 (file)
@@ -54,13 +54,13 @@ struct reg_cache
        int num_regs;
 };
 
-typedef struct reg_arch_type_s
+struct reg_arch_type
 {
        int id;
        int (*get)(reg_t *reg);
        int (*set)(reg_t *reg, uint8_t *buf);
-       struct reg_arch_type_s *next;
-} reg_arch_type_t;
+       struct reg_arch_type *next;
+};
 
 reg_t* register_get_by_name(struct reg_cache *first,
                const char *name, bool search_all);
@@ -68,7 +68,7 @@ struct reg_cache** register_get_last_cache_p(struct reg_cache **first);
 
 int register_reg_arch_type(int (*get)(reg_t *reg),
                int (*set)(reg_t *reg, uint8_t *buf));
-reg_arch_type_t* register_get_arch_type(int id);
+struct reg_arch_type* register_get_arch_type(int id);
 
 void register_init_dummy(reg_t *reg);
 
index eaa29db11f3fa762a07f243cf96cd01601fd786d..8932266abb486df3cfb08a700588a37f0cd47c4e 100644 (file)
@@ -1961,7 +1961,7 @@ COMMAND_HANDLER(handle_reg_command)
 
                if (reg->valid == 0)
                {
-                       reg_arch_type_t *arch_type = register_get_arch_type(reg->arch_type);
+                       struct reg_arch_type *arch_type = register_get_arch_type(reg->arch_type);
                        arch_type->get(reg);
                }
                value = buf_to_str(reg->value, reg->size, 16);
@@ -1976,7 +1976,7 @@ COMMAND_HANDLER(handle_reg_command)
                uint8_t *buf = malloc(CEIL(reg->size, 8));
                str_to_buf(args[1], strlen(args[1]), buf, reg->size, 0);
 
-               reg_arch_type_t *arch_type = register_get_arch_type(reg->arch_type);
+               struct reg_arch_type *arch_type = register_get_arch_type(reg->arch_type);
                arch_type->set(reg, buf);
 
                value = buf_to_str(reg->value, reg->size, 16);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)