flash: mxc nfc(v1) : fix incorrect address in spare area for biswap command 92/1692/3
authorGaëtan Carlier <gcembed@gmail.com>
Sat, 12 Oct 2013 19:09:21 +0000 (21:09 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Wed, 16 Oct 2013 11:36:21 +0000 (11:36 +0000)
For NFC v1 (i.MX27), swapping must be done between offset 464 of Main
buffer and offset 4 of Spare buffer.

Change-Id: I09c2036e88770032da87d5846cd2094847f47b46
Signed-off-by: Gaetan Carlier <gcembed@gmail.com>
Reviewed-on: http://openocd.zylin.com/1692
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/flash/nand/mxc.c

index 73232de73e926d3a3fc671c5a9c28db56a74c955..fb66b6d385114937f3334687e411e4e8b1172368 100644 (file)
@@ -543,7 +543,7 @@ static int mxc_write_page(struct nand_device *nand, uint32_t page,
                swap2 = (swap1 << 8) | (swap2 & 0xFF);
                target_write_u16(target, MXC_NF_MAIN_BUFFER3 + 464, new_swap1);
                if (nfc_is_v1())
-                       target_write_u16(target, MXC_NF_V1_SPARE_BUFFER3, swap2);
+                       target_write_u16(target, MXC_NF_V1_SPARE_BUFFER3 + 4, swap2);
                else
                        target_write_u16(target, MXC_NF_V2_SPARE_BUFFER3, swap2);
        }
@@ -662,7 +662,7 @@ static int mxc_read_page(struct nand_device *nand, uint32_t page,
                /* BI-swap -  work-around of mxc NFC for NAND device with page == 2k */
                target_read_u16(target, MXC_NF_MAIN_BUFFER3 + 464, &swap1);
                if (nfc_is_v1())
-                       SPARE_BUFFER3 = MXC_NF_V1_SPARE_BUFFER3;
+                       SPARE_BUFFER3 = MXC_NF_V1_SPARE_BUFFER3 + 4;
                else
                        SPARE_BUFFER3 = MXC_NF_V2_SPARE_BUFFER3;
                target_read_u16(target, SPARE_BUFFER3, &swap2);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)