aarch64: remove references to armv7-r 63/3763/6
authorMatthias Welwarsky <matthias.welwarsky@sysgo.com>
Thu, 1 Sep 2016 20:27:28 +0000 (22:27 +0200)
committerMatthias Welwarsky <matthias.welwarsky@sysgo.com>
Fri, 10 Feb 2017 13:01:39 +0000 (14:01 +0100)
aarch64 target doesn't support the -r profile anyway.

Change-Id: Iaa470ed9f95ea495ab1bafdf401f55a1ebcefddf
Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
src/target/aarch64.c
src/target/armv8.h

index 948a2076380535ba9e7a9bd7232326c49682ca95..e215206b468293ef1f42886d2b4ff9964360b0ec 100644 (file)
@@ -2152,11 +2152,9 @@ static int aarch64_read_memory(struct target *target, target_addr_t address,
                size, count);
 
        /* determine if MMU was enabled on target stop */
-       if (!armv8->is_armv7r) {
-               retval = aarch64_mmu(target, &mmu_enabled);
-               if (retval != ERROR_OK)
-                       return retval;
-       }
+       retval = aarch64_mmu(target, &mmu_enabled);
+       if (retval != ERROR_OK)
+               return retval;
 
        if (armv8->memory_ap_available && (apsel == armv8->memory_ap->ap_num)) {
                if (mmu_enabled) {
@@ -2209,16 +2207,13 @@ static int aarch64_write_phys_memory(struct target *target,
                } else {
 
                        /* write memory through APB-AP */
-                       if (!armv8->is_armv7r) {
-                               retval = aarch64_mmu_modify(target, 0);
-                               if (retval != ERROR_OK)
-                                       return retval;
-                       }
+                       retval = aarch64_mmu_modify(target, 0);
+                       if (retval != ERROR_OK)
+                               return retval;
                        return aarch64_write_apb_ap_memory(target, address, size, count, buffer);
                }
        }
 
-
        /* REVISIT this op is generic ARMv7-A/R stuff */
        if (retval == ERROR_OK && target->state == TARGET_HALTED) {
                struct arm_dpm *dpm = armv8->arm.dpm;
@@ -2291,11 +2286,9 @@ static int aarch64_write_memory(struct target *target, target_addr_t address,
                  "; count %" PRId32, address, size, count);
 
        /* determine if MMU was enabled on target stop */
-       if (!armv8->is_armv7r) {
-               retval = aarch64_mmu(target, &mmu_enabled);
-               if (retval != ERROR_OK)
-                       return retval;
-       }
+       retval = aarch64_mmu(target, &mmu_enabled);
+       if (retval != ERROR_OK)
+               return retval;
 
        if (armv8->memory_ap_available && (apsel == armv8->memory_ap->ap_num)) {
                LOG_DEBUG("Writing memory to address 0x%" TARGET_PRIxADDR "; size %"
@@ -2580,8 +2573,6 @@ static int aarch64_target_create(struct target *target, Jim_Interp *interp)
 {
        struct aarch64_common *aarch64 = calloc(1, sizeof(struct aarch64_common));
 
-       aarch64->armv8_common.is_armv7r = false;
-
        return aarch64_init_arch_info(target, aarch64, target->tap);
 }
 
index 884d39a3ac9fa33218c9925c495f61e908bacc1e..169bcb386a8dc3d5a3a5ff9ea49563c23ded0671 100644 (file)
@@ -139,7 +139,6 @@ struct armv8_common {
        uint8_t multi_processor_system;
        uint8_t cluster_id;
        uint8_t cpu_id;
-       bool is_armv7r;
 
        /* armv8 aarch64 need below information for page translation */
        uint8_t va_size;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)