Fix support for single-bank stm32l4 processors 13/4913/3
authorArmin van der Togt <armin@otheruse.nl>
Thu, 14 Feb 2019 14:35:07 +0000 (15:35 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Thu, 21 Feb 2019 06:19:55 +0000 (06:19 +0000)
Recent patches for STM32L4+ assumed all STM32L4 processors have a dual-
bank option. This is not the case for STM32L4{3,4,5,6}xx processors and
therefore, these processors (like STM32L433) failed when attempting to
flash the second half of the flash memory. This patch fixed this issue.
Tested on STM32L433xC, STM32L476xG and STM32L471xG.

Change-Id: I8262ba4f05190802c5868d753f3e7af50e581811
Signed-off-by: Armin van der Togt <armin@otheruse.nl>
Reviewed-on: http://openocd.zylin.com/4913
Tested-by: jenkins
Reviewed-by: Peter Tettelaar <peter@float-iot.nl>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-by: Mark Schulte <mschulte@lyft.com>
src/flash/nor/stm32l4x.c

index 7c5811ead8ce4b0e04fa22936ec79aa24fa971ca..7d1e4298406d0c0b2af50f6d4739d3b456752a77 100644 (file)
@@ -678,8 +678,9 @@ static int stm32l4_probe(struct flash_bank *bank)
                        /* Invalid FLASH size for this device. */
                        LOG_WARNING("Invalid flash size for STM32L4+ family device.");
                        return ERROR_FAIL;
-               default:
-                       /* Other L4 family devices have 2K pages. */
+               case 0x461:
+               case 0x415:
+                       /* These are dual-bank devices, we need to check the OPT_DBANK_LE_1M bit here */
                        page_size = 2048;
                        num_pages = flash_size_in_kb / 2;
                        /* check that calculation result makes sense */
@@ -689,6 +690,16 @@ static int stm32l4_probe(struct flash_bank *bank)
                        else
                                stm32l4_info->bank2_start = num_pages / 2;
                        break;
+               case 0x462:
+               case 0x435:
+               default:
+                       /* These are single-bank devices */
+                       page_size = 2048;
+                       num_pages = flash_size_in_kb / 2;
+                       /* check that calculation result makes sense */
+                       assert(num_pages > 0);
+                       stm32l4_info->bank2_start = UINT16_MAX;
+                       break;
        }
 
        /* Release sector table if allocated. */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)