image: remove assignments to local variables that is never read
authorØyvind Harboe <oyvind.harboe@zylin.com>
Thu, 10 Nov 2011 17:19:21 +0000 (18:19 +0100)
committerSpencer Oliver <spen@spen-soft.co.uk>
Thu, 10 Nov 2011 21:30:15 +0000 (21:30 +0000)
Change-Id: I1a5e968f165e060fd4aa7c023ad870a9e21bb5dd
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/191
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/target/image.c

index 8f437c035797a7901ed9295f2ada0cc5427d89b2..d1db136b7716b43a8cfb84ac16c9a8a161035582 100644 (file)
@@ -347,7 +347,6 @@ static int image_ihex_buffer_complete_inner(struct image *image, char *lpszLine,
                }
 
                sscanf(&lpszLine[bytes_read], "%2" SCNx32 , &checksum);
                }
 
                sscanf(&lpszLine[bytes_read], "%2" SCNx32 , &checksum);
-               bytes_read += 2;
 
                if ((uint8_t)checksum != (uint8_t)(~cal_checksum + 1))
                {
 
                if ((uint8_t)checksum != (uint8_t)(~cal_checksum + 1))
                {
@@ -546,9 +545,7 @@ static int image_elf_read_section(struct image *image, int section, uint32_t off
                        LOG_ERROR("cannot read ELF segment content, read failed");
                        return retval;
                }
                        LOG_ERROR("cannot read ELF segment content, read failed");
                        return retval;
                }
-               buffer += read_size;
                size -= read_size;
                size -= read_size;
-               offset += read_size;
                *size_read += read_size;
                /* need more data ? */
                if (!size)
                *size_read += read_size;
                /* need more data ? */
                if (!size)
@@ -718,7 +715,6 @@ static int image_mot_buffer_complete_inner(struct image *image, char *lpszLine,
                /* account for checksum, will always be 0xFF */
                sscanf(&lpszLine[bytes_read], "%2" SCNx32 , &checksum);
                cal_checksum += (uint8_t)checksum;
                /* account for checksum, will always be 0xFF */
                sscanf(&lpszLine[bytes_read], "%2" SCNx32 , &checksum);
                cal_checksum += (uint8_t)checksum;
-               bytes_read += 2;
 
                if (cal_checksum != 0xFF)
                {
 
                if (cal_checksum != 0xFF)
                {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)