svf: -Wshadow warning fixes
authorØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 16 Jun 2010 06:17:27 +0000 (08:17 +0200)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 16 Jun 2010 06:17:27 +0000 (08:17 +0200)
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/svf/svf.c

index 6e951e24f65ecb6368294a4754af4aa485ad191d..62e2324883a9c2acb5f215f115879f688eb81046 100644 (file)
@@ -272,7 +272,7 @@ static unsigned svf_get_mask_u32(int bitlen)
 int svf_add_statemove(tap_state_t state_to)
 {
        tap_state_t state_from = cmd_queue_cur_state;
 int svf_add_statemove(tap_state_t state_to)
 {
        tap_state_t state_from = cmd_queue_cur_state;
-       uint8_t index;
+       unsigned index_var;
 
        /* when resetting, be paranoid and ignore current state */
        if (state_to == TAP_RESET) {
 
        /* when resetting, be paranoid and ignore current state */
        if (state_to == TAP_RESET) {
@@ -280,18 +280,18 @@ int svf_add_statemove(tap_state_t state_to)
                return ERROR_OK;
        }
 
                return ERROR_OK;
        }
 
-       for (index = 0; index < ARRAY_SIZE(svf_statemoves); index++)
+       for (index_var = 0; index_var < ARRAY_SIZE(svf_statemoves); index_var++)
        {
        {
-               if ((svf_statemoves[index].from == state_from)
-                       && (svf_statemoves[index].to == state_to))
+               if ((svf_statemoves[index_var].from == state_from)
+                       && (svf_statemoves[index_var].to == state_to))
                {
                        /* recorded path includes current state ... avoid extra TCKs! */
                {
                        /* recorded path includes current state ... avoid extra TCKs! */
-                       if (svf_statemoves[index].num_of_moves > 1)
-                               jtag_add_pathmove(svf_statemoves[index].num_of_moves - 1,
-                                               svf_statemoves[index].paths + 1);
+                       if (svf_statemoves[index_var].num_of_moves > 1)
+                               jtag_add_pathmove(svf_statemoves[index_var].num_of_moves - 1,
+                                               svf_statemoves[index_var].paths + 1);
                        else
                        else
-                               jtag_add_pathmove(svf_statemoves[index].num_of_moves,
-                                               svf_statemoves[index].paths);
+                               jtag_add_pathmove(svf_statemoves[index_var].num_of_moves,
+                                               svf_statemoves[index_var].paths);
                        return ERROR_OK;
                }
        }
                        return ERROR_OK;
                }
        }
@@ -723,22 +723,22 @@ static int svf_copy_hexstring_to_binary(char *str, uint8_t **bin, int orig_bit_l
 
 static int svf_check_tdo(void)
 {
 
 static int svf_check_tdo(void)
 {
-       int i, len, index;
+       int i, len, index_var;
 
        for (i = 0; i < svf_check_tdo_para_index; i++)
        {
 
        for (i = 0; i < svf_check_tdo_para_index; i++)
        {
-               index = svf_check_tdo_para[i].buffer_offset;
+               index_var = svf_check_tdo_para[i].buffer_offset;
                len = svf_check_tdo_para[i].bit_len;
                if ((svf_check_tdo_para[i].enabled)
                len = svf_check_tdo_para[i].bit_len;
                if ((svf_check_tdo_para[i].enabled)
-                       && buf_cmp_mask(&svf_tdi_buffer[index], &svf_tdo_buffer[index], &svf_mask_buffer[index], len))
+                       && buf_cmp_mask(&svf_tdi_buffer[index_var], &svf_tdo_buffer[index_var], &svf_mask_buffer[index_var], len))
                {
                        unsigned bitmask;
                        unsigned received, expected, tapmask;
                        bitmask = svf_get_mask_u32(svf_check_tdo_para[i].bit_len);
 
                {
                        unsigned bitmask;
                        unsigned received, expected, tapmask;
                        bitmask = svf_get_mask_u32(svf_check_tdo_para[i].bit_len);
 
-                       memcpy(&received, svf_tdi_buffer + index, sizeof(unsigned));
-                       memcpy(&expected, svf_tdo_buffer + index, sizeof(unsigned));
-                       memcpy(&tapmask, svf_mask_buffer + index, sizeof(unsigned));
+                       memcpy(&received, svf_tdi_buffer + index_var, sizeof(unsigned));
+                       memcpy(&expected, svf_tdo_buffer + index_var, sizeof(unsigned));
+                       memcpy(&tapmask, svf_mask_buffer + index_var, sizeof(unsigned));
                        LOG_ERROR("tdo check error at line %d",
                                          svf_check_tdo_para[i].line_num);
                        LOG_ERROR("read = 0x%X, want = 0x%X, mask = 0x%X",
                        LOG_ERROR("tdo check error at line %d",
                                          svf_check_tdo_para[i].line_num);
                        LOG_ERROR("read = 0x%X, want = 0x%X, mask = 0x%X",

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)