transport: fix LOG_DEBUG gaffe
authorsimon qian <simonqian.openocd@gmail.com>
Thu, 13 Jan 2011 07:25:22 +0000 (08:25 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Thu, 13 Jan 2011 07:28:29 +0000 (08:28 +0100)
LOG_DEBUG() arguments are only evaluated when DEBUG logging
is enabled, do not use arguments that have side effects
like foo++.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/jtag/transport.c

index 5033ebc6df4a8ce498f6c79d4f781bef131c98f6..f570103cc7df2f84b4221bbd2a2a82f32a6817fe 100644 (file)
@@ -125,8 +125,10 @@ int allow_transports(struct command_context *ctx, const char **vector)
        } else {
                /* guard against user config errors */
                LOG_WARNING("must select a transport.");
-               while (*vector)
-                       LOG_DEBUG("allow transport '%s'", *vector++);
+               while (*vector) {
+                       LOG_DEBUG("allow transport '%s'", *vector);
+                       vector++;
+               }
                return ERROR_OK;
        }
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)