jtag: remove jtag_get_end_state()'s that should be unecessary
authorØyvind Harboe <oyvind.harboe@zylin.com>
Thu, 18 Mar 2010 17:31:58 +0000 (18:31 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Fri, 19 Mar 2010 07:31:44 +0000 (08:31 +0100)
By a bit of code inspection it seems like all of these
instances of jtag_get_end_state() can be unambigously
replaced by constants.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/jtag/zy1000/zy1000.c
src/target/arm7_9_common.c
src/target/arm7tdmi.c
src/target/arm9tdmi.c
src/target/embeddedice.h

index 177d286..9b8b480 100644 (file)
@@ -849,7 +849,7 @@ void embeddedice_write_dcc(struct jtag_tap *tap, int reg_addr, uint8_t *buffer,
                }
        } else
        {
-               tap_state_t end_state = jtag_get_end_state();
+               tap_state_t end_state = TAP_IDLE;
                tap_state_t shift_end_state;
                if (post_bits == 0)
                        shift_end_state = end_state;
index 85c6816..4c8d83d 100644 (file)
@@ -995,7 +995,7 @@ int arm7_9_assert_reset(struct target *target)
                         * certain ARM9 cores (maybe more) - AT91SAM9260
                         * and STR9
                         */
-                       jtag_add_runtest(1, jtag_get_end_state());
+                       jtag_add_runtest(1, TAP_IDLE);
                }
                else
                {
index 25151ff..f145275 100644 (file)
@@ -104,9 +104,9 @@ static __inline int arm7tdmi_clock_out_inner(struct arm_jtag *jtag_info, uint32_
                        2,
                        arm7tdmi_num_bits,
                        values,
-                       jtag_get_end_state());
+                       TAP_DRPAUSE);
 
-       jtag_add_runtest(0, jtag_get_end_state());
+       jtag_add_runtest(0, TAP_DRPAUSE);
 
        return ERROR_OK;
 }
index b4b6f04..4f28599 100644 (file)
@@ -186,7 +186,7 @@ int arm9tdmi_clock_out(struct arm_jtag *jtag_info, uint32_t instr,
                jtag_add_dr_scan(jtag_info->tap, 3, fields, TAP_DRPAUSE);
        }
 
-       jtag_add_runtest(0, jtag_get_end_state());
+       jtag_add_runtest(0, TAP_DRPAUSE);
 
 #ifdef _DEBUG_INSTRUCTION_EXECUTION_
        {
index cd48ce6..d278115 100644 (file)
@@ -128,7 +128,7 @@ static __inline__ void embeddedice_write_reg_inner(struct jtag_tap *tap, int reg
                        2,
                        embeddedice_num_bits,
                        values,
-                       jtag_get_end_state());
+                       TAP_IDLE);
 }
 
 void embeddedice_write_dcc(struct jtag_tap *tap, int reg_addr, uint8_t *buffer, int little, int count);