fix return code from dsp5680xx_read
authorRodrigo L. Rosa <rodrigorosa.LG@gmail.com>
Fri, 5 Aug 2011 18:40:05 +0000 (11:40 -0700)
committerRodrigo L. Rosa <rodrigorosa.LG@gmail.com>
Wed, 10 Aug 2011 20:08:14 +0000 (13:08 -0700)
it returned ERROR_OK even though it actually failed.
this made the Tcl interface report success, though it had not succeeded.

src/target/dsp5680xx.c

index e5984238bdd01f974a13cf340302771741ab2750..c25eabf6696a2f35f887178c7a2546846e3d7a70 100644 (file)
@@ -726,7 +726,7 @@ static int dsp5680xx_read_32_single(struct target * target, uint32_t address, ui
 static int dsp5680xx_read(struct target * target, uint32_t address, unsigned size, unsigned count, uint8_t * buffer){
   if(target->state != TARGET_HALTED){
     LOG_USER("Target must be halted.");
-    return ERROR_OK;
+    return ERROR_FAIL;
   }
   int retval = ERROR_OK;
   int pmem = 1;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)