Minor regression bugfix for the jtag_tap_handle_event() case
authordbrownell <dbrownell@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sun, 20 Sep 2009 07:46:22 +0000 (07:46 +0000)
committerdbrownell <dbrownell@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Sun, 20 Sep 2009 07:46:22 +0000 (07:46 +0000)
for disabling TAPs.  We don't actually know how to make any
JRCs which do that yet; but when we do, this will matter.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2735 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/jtag/tcl.c

index d9047ac92087a8910d6c7f921965fa6df7d5cb63..04fca22770ce545da0c126c5571bbbc3d0771aa2 100644 (file)
@@ -373,13 +373,17 @@ static void jtag_tap_handle_event(jtag_tap_t *tap, enum jtag_event e)
                                        Jim_GetString(jteap->body, NULL));
                        if (Jim_EvalObj(interp, jteap->body) != JIM_OK) {
                                Jim_PrintErrorMessage(interp);
-                       } else {
+                       } else switch (e) {
+                       case JTAG_TAP_EVENT_ENABLE:
+                       case JTAG_TAP_EVENT_DISABLE:
                                /* NOTE:  we currently assume the handlers
                                 * can't fail.  That presumes later code
                                 * will be verifying the scan chains ...
                                 */
-                               if (e == JTAG_TAP_EVENT_ENABLE)
-                                       tap->enabled = true;
+                               tap->enabled = (e == JTAG_TAP_EVENT_ENABLE);
+                               break;
+                       default:
+                               break;
                        }
                }
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)