jtag: remove opendous clang warnings
authorSpencer Oliver <spen@spen-soft.co.uk>
Tue, 22 May 2012 11:17:49 +0000 (12:17 +0100)
committerPeter Stuge <peter@stuge.se>
Tue, 22 May 2012 22:53:07 +0000 (22:53 +0000)
Change-Id: I0285c99507931e7d13aad36f4fc559c29a52faca
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/655
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
src/jtag/drivers/opendous.c

index c973bd233045f186510008e5045d4dde6f1b30e7..165bec6a08a5bf9507b4d46991b3b4665a2d2334 100644 (file)
@@ -557,23 +557,25 @@ void opendous_tap_append_scan(int length, uint8_t *buffer, struct scan_command *
  * For the purpose of padding we assume that we are in idle or pause state. */
 int opendous_tap_execute(void)
 {
-       int byte_length, byte_length_out;
+       int byte_length;
        int i, j;
        int result;
-       int output_counter;
+
+#ifdef _DEBUG_USB_COMMS_
+       int byte_length_out;
+#endif
 
        if (tap_length > 0) {
 
                /* memset(tdo_buffer,0,OPENDOUS_TAP_BUFFER_SIZE); */
                /* LOG_INFO("OPENDOUS tap execute %d",tap_length); */
                byte_length = (tap_length + 3) / 4;
-               byte_length_out = (tap_length + 7) / 8;
 
 #ifdef _DEBUG_USB_COMMS_
+               byte_length_out = (tap_length + 7) / 8;
                LOG_DEBUG("opendous is sending %d bytes", byte_length);
 #endif
 
-               output_counter = 0;
                for (j = 0, i = 0; j <  byte_length;) {
 
                        int recieve;
@@ -601,10 +603,9 @@ int opendous_tap_execute(void)
                        j += transmit;
                }
 
-               result = byte_length_out;
 #ifdef _DEBUG_USB_COMMS_
-               LOG_DEBUG("opendous tap result %d", result);
-               opendous_debug_buffer(tdo_buffer, result);
+               LOG_DEBUG("opendous tap result %d", byte_length_out);
+               opendous_debug_buffer(tdo_buffer, byte_length_out);
 #endif
 
                /* LOG_INFO("eStick tap execute %d",tap_length); */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)