log: improve log_callback_fn signature
authorZachary T Welch <zw@superlucidity.net>
Mon, 9 Nov 2009 14:12:02 +0000 (06:12 -0800)
committerZachary T Welch <zw@superlucidity.net>
Wed, 11 Nov 2009 13:40:48 +0000 (05:40 -0800)
Use unsigned type for line number in log_callback_fn signature.

src/helper/command.c
src/helper/log.h
src/server/gdb_server.c
src/server/telnet_server.c

index 5d69ffb3fb80aec3254793962a2b8479671dc12f..5f3c88dc0372dd4d4917a47c25e6be9025a81c2b 100644 (file)
@@ -49,10 +49,10 @@ Jim_Interp *interp = NULL;
 
 int run_command(command_context_t *context, command_t *c, char *words[], int num_words);
 
 
 int run_command(command_context_t *context, command_t *c, char *words[], int num_words);
 
-static void tcl_output(void *privData, const char *file, int line, const char *function, const char *string)
+static void tcl_output(void *privData, const char *file, unsigned line,
+               const char *function, const char *string)
 {
        Jim_Obj *tclOutput = (Jim_Obj *)privData;
 {
        Jim_Obj *tclOutput = (Jim_Obj *)privData;
-
        Jim_AppendString(interp, tclOutput, string, strlen(string));
 }
 
        Jim_AppendString(interp, tclOutput, string, strlen(string));
 }
 
index 15bd3c86236a401f0fdd16e00a858a92f251967d..aabd1be250c2a40efa29819ec2e317f814c6b406 100644 (file)
@@ -85,7 +85,7 @@ void log_catch(void);
 void log_rethrow(void);
 
 
 void log_rethrow(void);
 
 
-typedef void (*log_callback_fn)(void *priv, const char *file, int line,
+typedef void (*log_callback_fn)(void *priv, const char *file, unsigned line,
                const char *function, const char *string);
 
 typedef struct log_callback_s
                const char *function, const char *string);
 
 typedef struct log_callback_s
index 284def3ca755827f509602e7bc5a2e05cf3f6586..21b58d0e4581fde929e99d587c111357b05a5ba9 100644 (file)
@@ -49,7 +49,7 @@ extern int gdb_error(connection_t *connection, int retval);
 static unsigned short gdb_port = 3333;
 static const char *DIGITS = "0123456789abcdef";
 
 static unsigned short gdb_port = 3333;
 static const char *DIGITS = "0123456789abcdef";
 
-static void gdb_log_callback(void *priv, const char *file, int line,
+static void gdb_log_callback(void *priv, const char *file, unsigned line,
                const char *function, const char *string);
 
 /* number of gdb connections, mainly to supress gdb related debugging spam
                const char *function, const char *string);
 
 /* number of gdb connections, mainly to supress gdb related debugging spam
@@ -1956,7 +1956,7 @@ int gdb_detach(connection_t *connection, target_t *target)
        return gdb_put_packet(connection, "OK", 2);
 }
 
        return gdb_put_packet(connection, "OK", 2);
 }
 
-static void gdb_log_callback(void *priv, const char *file, int line,
+static void gdb_log_callback(void *priv, const char *file, unsigned line,
                const char *function, const char *string)
 {
        connection_t *connection = priv;
                const char *function, const char *string)
 {
        connection_t *connection = priv;
index 84959e3a0f37a547ca203ddf77d48df190e90b4b..b77deff139bcaa203611b298bb8849619292180d 100644 (file)
@@ -101,7 +101,7 @@ int telnet_output(struct command_context_s *cmd_ctx, const char* line)
        return telnet_outputline(connection, line);
 }
 
        return telnet_outputline(connection, line);
 }
 
-void telnet_log_callback(void *priv, const char *file, int line,
+void telnet_log_callback(void *priv, const char *file, unsigned line,
                const char *function, const char *string)
 {
        connection_t *connection = priv;
                const char *function, const char *string)
 {
        connection_t *connection = priv;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)