flash: remove lpc2000 clang warnings
authorSpencer Oliver <spen@spen-soft.co.uk>
Mon, 13 Aug 2012 10:35:20 +0000 (11:35 +0100)
committerFreddie Chopin <freddie.chopin@gmail.com>
Fri, 24 Aug 2012 16:50:25 +0000 (16:50 +0000)
By Initialising the param_table we remove the clang warning's.
We are also make sure we are not passing any rogue values to lpc2000_iap_call.

Change-Id: Idb3b0077d1dae5f03dedab1d46d01140fe9ffb10
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/777
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/flash/nor/lpc2000.c

index f3d8f9e9c3b8b6979e6ac5122e4acdb1fce4410f..7b247f89e5232dc935c2bfe4994401cd8a1b570a 100644 (file)
@@ -422,7 +422,7 @@ static int lpc2000_iap_call(struct flash_bank *bank,
 
 static int lpc2000_iap_blank_check(struct flash_bank *bank, int first, int last)
 {
-       uint32_t param_table[5];
+       uint32_t param_table[5] = {0};
        uint32_t result_table[4];
        int status_code;
        int i;
@@ -512,7 +512,7 @@ FLASH_BANK_COMMAND_HANDLER(lpc2000_flash_bank_command)
 static int lpc2000_erase(struct flash_bank *bank, int first, int last)
 {
        struct lpc2000_flash_bank *lpc2000_info = bank->driver_priv;
-       uint32_t param_table[5];
+       uint32_t param_table[5] = {0};
        uint32_t result_table[4];
        int status_code;
 
@@ -573,7 +573,7 @@ static int lpc2000_write(struct flash_bank *bank, uint8_t *buffer, uint32_t offs
        uint32_t bytes_written = 0;
        int first_sector = 0;
        int last_sector = 0;
-       uint32_t param_table[5];
+       uint32_t param_table[5] = {0};
        uint32_t result_table[4];
        int status_code;
        int i;
@@ -772,7 +772,7 @@ static int get_lpc2000_info(struct flash_bank *bank, char *buf, int buf_size)
 
 COMMAND_HANDLER(lpc2000_handle_part_id_command)
 {
-       uint32_t param_table[5];
+       uint32_t param_table[5] = {0};
        uint32_t result_table[4];
        int status_code;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)