target: factor init to 'target init'
authorZachary T Welch <zw@superlucidity.net>
Tue, 1 Dec 2009 02:45:38 +0000 (18:45 -0800)
committerZachary T Welch <zw@superlucidity.net>
Wed, 2 Dec 2009 21:26:23 +0000 (13:26 -0800)
Adds 'target init' command handler, called as part of 'init'.

src/openocd.c
src/target/target.c

index 79a30e77e176e4fb44a4f2a6303e1bcdd8a65fa5..12bcf443c4e5053d675b6e4d70a33919a13ff397 100644 (file)
@@ -111,11 +111,9 @@ COMMAND_HANDLER(handle_init_command)
 
        initialized = 1;
 
 
        initialized = 1;
 
-       command_context_mode(CMD_CTX, COMMAND_EXEC);
-
-       if (target_init(CMD_CTX) != ERROR_OK)
+       retval = command_run_line(CMD_CTX, "target init");
+       if (ERROR_OK != retval)
                return ERROR_FAIL;
                return ERROR_FAIL;
-       LOG_DEBUG("target init complete");
 
        if ((retval = jtag_interface_init(CMD_CTX)) != ERROR_OK)
        {
 
        if ((retval = jtag_interface_init(CMD_CTX)) != ERROR_OK)
        {
@@ -126,7 +124,6 @@ COMMAND_HANDLER(handle_init_command)
 
        /* Try to initialize & examine the JTAG chain at this point, but
         * continue startup regardless */
 
        /* Try to initialize & examine the JTAG chain at this point, but
         * continue startup regardless */
-       command_context_mode(CMD_CTX, COMMAND_CONFIG);
        if (command_run_line(CMD_CTX, "jtag init") == ERROR_OK)
        {
                command_context_mode(CMD_CTX, COMMAND_EXEC);
        if (command_run_line(CMD_CTX, "jtag init") == ERROR_OK)
        {
                command_context_mode(CMD_CTX, COMMAND_EXEC);
index abf8bfd9bbe08427f28927907762315aca293ccb..4013442612dd8489074a89911ef7ee27a59671ca 100644 (file)
@@ -787,6 +787,23 @@ int target_init(struct command_context *cmd_ctx)
        return ERROR_OK;
 }
 
        return ERROR_OK;
 }
 
+COMMAND_HANDLER(handle_target_init_command)
+{
+       if (CMD_ARGC != 0)
+               return ERROR_COMMAND_SYNTAX_ERROR;
+
+       static bool target_initialized = false;
+       if (target_initialized)
+       {
+               LOG_INFO("'target init' has already been called");
+               return ERROR_OK;
+       }
+       target_initialized = true;
+
+       LOG_DEBUG("Initializing targets...");
+       return target_init(CMD_CTX);
+}
+
 int target_register_event_callback(int (*callback)(struct target *target, enum target_event event, void *priv), void *priv)
 {
        struct target_event_callback **callbacks_p = &target_event_callbacks;
 int target_register_event_callback(int (*callback)(struct target *target, enum target_event event, void *priv), void *priv)
 {
        struct target_event_callback **callbacks_p = &target_event_callbacks;
@@ -4786,6 +4803,12 @@ COMMAND_HANDLER(handle_fast_load_command)
 }
 
 static const struct command_registration target_command_handlers[] = {
 }
 
 static const struct command_registration target_command_handlers[] = {
+       {
+               .name = "init",
+               .mode = COMMAND_CONFIG,
+               .handler = &handle_target_init_command,
+               .help = "initialize targets",
+       },
        {
                .name = "targets",
                .handler = &handle_targets_command,
        {
                .name = "targets",
                .handler = &handle_targets_command,

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)