ARM11: use now-generic memory utils
authorDavid Brownell <dbrownell@users.sourceforge.net>
Sun, 15 Nov 2009 18:35:47 +0000 (10:35 -0800)
committerDavid Brownell <dbrownell@users.sourceforge.net>
Sun, 15 Nov 2009 18:35:47 +0000 (10:35 -0800)
Now the ARM11 cores can use the renamed arm_checksum_memory()
and arm_blank_check_memory() routines ... do so.

Sanity checked with "flash erase_check" of both NOR banks on an
OMAP2420 ... the algorithm code dumped four lines of of "poll"
status after each of almost 520 blocks (yes, *very* annoying) but
gave plausible results after producing that spam.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
NEWS
src/target/arm11.c

diff --git a/NEWS b/NEWS
index 813ecda43d9483575f526b76434905c21cc5585d..7387d705747031ab65d3f2b8724dd07553419fdb 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -8,8 +8,16 @@ JTAG Layer:
 
 Boundary Scan:
 Target Layer:
 
 Boundary Scan:
 Target Layer:
+       ARM11
+               - Preliminary ETM and ETB hookup
+               - accelerated "flash erase_check"
+               - accelerated GDB memory checksum
+
 Flash Layer:
 Board, Target, and Interface Configuration Scripts:
 Flash Layer:
 Board, Target, and Interface Configuration Scripts:
+       ARM9
+               - ETM and ETB hookup for iMX2* targets
+
 Documentation:
 Build and Release:
 
 Documentation:
 Build and Release:
 
index 0b2fa2cf5e8c4d295a4fc0883a7e7c4d9ae27d35..348dd8755f61c4e2a049a5605f98638a049a68ed 100644 (file)
@@ -1551,16 +1551,6 @@ static int arm11_bulk_write_memory(struct target *target,
        return arm11_write_memory(target, address, 4, count, buffer);
 }
 
        return arm11_write_memory(target, address, 4, count, buffer);
 }
 
-/* here we have nothing target specific to contribute, so we fail and then the
- * fallback code will read data from the target and calculate the CRC on the
- * host.
- */
-static int arm11_checksum_memory(struct target *target,
-               uint32_t address, uint32_t count, uint32_t* checksum)
-{
-       return ERROR_FAIL;
-}
-
 /* target break-/watchpoint control
 * rw: 0 = write, 1 = read, 2 = access
 */
 /* target break-/watchpoint control
 * rw: 0 = write, 1 = read, 2 = access
 */
@@ -2203,7 +2193,8 @@ struct target_type arm11_target = {
 
        .bulk_write_memory =    arm11_bulk_write_memory,
 
 
        .bulk_write_memory =    arm11_bulk_write_memory,
 
-       .checksum_memory =      arm11_checksum_memory,
+       .checksum_memory =      arm_checksum_memory,
+       .blank_check_memory =   arm_blank_check_memory,
 
        .add_breakpoint =       arm11_add_breakpoint,
        .remove_breakpoint =    arm11_remove_breakpoint,
 
        .add_breakpoint =       arm11_add_breakpoint,
        .remove_breakpoint =    arm11_remove_breakpoint,

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)