command_registration: add empty usage field to chained commands 17/5017/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Fri, 4 Jan 2019 14:13:53 +0000 (15:13 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Sun, 7 Apr 2019 07:17:36 +0000 (08:17 +0100)
Chained command require a subcommand as first argument. The usage
field for chained commands is not really important because the
"help" command will list all the subcommands with their respective
usage.

Add a empty usage field on all chained command.
The command "jlink config" can be either followed by a subcommand
or used alone, so use a dedicated usage string.

Change-Id: I43c3f8a766f96a9bdab4e709e3c90713be41fcef
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5017
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
14 files changed:
src/flash/nand/mxc.c
src/flash/nor/faux.c
src/flash/nor/max32xxx.c
src/flash/nor/tcl.c
src/hello.c
src/helper/command.c
src/jtag/drivers/dummy.c
src/jtag/drivers/jlink.c
src/target/arm_cti.c
src/target/arm_dap.c
src/target/etb.c
src/target/etm_dummy.c
src/target/target.c
src/target/testee.c

index 6be416057bc4a19b05a733679177e1b03e19effb..6069c62685aa034fbb0074ec74cd555f48a44a62 100644 (file)
@@ -193,7 +193,8 @@ static const struct command_registration mxc_nand_command_handler[] = {
                .name = "mxc",
                .mode = COMMAND_ANY,
                .help = "MXC NAND flash controller commands",
-               .chain = mxc_sub_command_handlers
+               .chain = mxc_sub_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 49b6dccd0179268f4ae599b934baf37831b8ad10..a894d0398ee25d38e9491778c81c1d18c84de333 100644 (file)
@@ -109,6 +109,7 @@ static const struct command_registration faux_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "faux flash command group",
                .chain = hello_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 12e3db9403530e942a7ab1872bf9e29106345ccf..f51f6e2a99d5d2a93fa3c50d75db3245bdaa191f 100644 (file)
@@ -977,6 +977,7 @@ static const struct command_registration max32xxx_command_handlers[] = {
                .mode = COMMAND_EXEC,
                .help = "max32xxx flash command group",
                .chain = max32xxx_exec_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 6e216e68ebfdc521e4d365465c0f2c8740aded53..6d2d2b816b8ee1408d92945b64ad48c91b548f48 100644 (file)
@@ -1260,6 +1260,7 @@ static const struct command_registration flash_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "NOR flash command group",
                .chain = flash_config_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 25938bcf88d75e5a45c2f07e5237a32823519e78..2afbba3a3e5f6a34de8c30b5de9e7fa875bd7f0b 100644 (file)
@@ -105,8 +105,8 @@ const struct command_registration hello_command_handlers[] = {
                .name = "foo",
                .mode = COMMAND_ANY,
                .help = "example command handler skeleton",
-
                .chain = foo_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 7a3c2d4fe47a6b129d55bdf3e76b7533c5b493b1..869eff559cdd0836b760744bd1052439e093807a 100644 (file)
@@ -1294,6 +1294,7 @@ static const struct command_registration command_builtin_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "core command group (introspection)",
                .chain = command_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index db1ba13a49f0870805a9afe467a693b6b31d5c32..4e5b6152c8d7beb06dbc1ea41be65f7da116860a 100644 (file)
@@ -136,8 +136,8 @@ static const struct command_registration dummy_command_handlers[] = {
                .name = "dummy",
                .mode = COMMAND_ANY,
                .help = "dummy interface driver commands",
-
                .chain = hello_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE,
 };
index 1eae827340d1e180693eab3d6c18bc61a5408a65..c81579ab29e9a39242f584f53c020b57aed6ecda 100644 (file)
@@ -1849,12 +1849,14 @@ static const struct command_registration jlink_subcommand_handlers[] = {
                .help = "access the device configuration. If no argument is given "
                        "this will show the device configuration",
                .chain = jlink_config_subcommand_handlers,
+               .usage = "[<cmd>]",
        },
        {
                .name = "emucom",
                .mode = COMMAND_EXEC,
                .help = "access EMUCOM channel",
-               .chain = jlink_emucom_subcommand_handlers
+               .chain = jlink_emucom_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
@@ -1865,6 +1867,7 @@ static const struct command_registration jlink_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "perform jlink management",
                .chain = jlink_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index f33379240d5b159ac8fb0f8c7ccd209f47c09c0b..3fa54d69c4bb2117c9248ecd5bdd58e7cfae4186 100644 (file)
@@ -576,6 +576,7 @@ static const struct command_registration cti_command_handlers[] = {
                .mode = COMMAND_CONFIG,
                .help = "CTI commands",
                .chain = cti_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 119e5117d2e5ffa186e1d055391e0ebc625f41f2..dd7ec9b5893f14ee57de953a94345253c16cf6e4 100644 (file)
@@ -373,6 +373,7 @@ static const struct command_registration dap_commands[] = {
                .mode = COMMAND_CONFIG,
                .help = "DAP commands",
                .chain = dap_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 98a90a556152b8799201137743da2c85ede77af8..7cd8b6cd5c8997c2147cc395661dbf2622b64b77 100644 (file)
@@ -441,6 +441,7 @@ static const struct command_registration etb_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "Embedded Trace Buffer command group",
                .chain = etb_config_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index b18ce17449b0ca0bc22740c863e558115f7a7b95..9f18d84a19475c9df1ad6b5557224d90066b197d 100644 (file)
@@ -66,6 +66,7 @@ static const struct command_registration etm_dummy_command_handlers[] = {
                .mode = COMMAND_ANY,
                .help = "Dummy ETM capture driver command group",
                .chain = etm_dummy_config_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 5295dd626815ee86dacb4698218014c0b8303168..084a2cffc27adaf0220471a2fe641e49ec189a12 100644 (file)
@@ -6096,8 +6096,8 @@ static const struct command_registration target_command_handlers[] = {
                .name = "target",
                .mode = COMMAND_CONFIG,
                .help = "configure target",
-
                .chain = target_subcommand_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };
index 5b6ccedd85906e1bd436c73a5fc97c6fdcee2c46..236ac9aba917496fc2c4894792e94f6dfdb2314f 100644 (file)
@@ -30,8 +30,8 @@ static const struct command_registration testee_command_handlers[] = {
                .name = "testee",
                .mode = COMMAND_ANY,
                .help = "testee target commands",
-
                .chain = hello_command_handlers,
+               .usage = "",
        },
        COMMAND_REGISTRATION_DONE
 };

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)