rtos/mqx: prevent crash with -rtos auto 41/2741/3
authorPaul Fertser <fercerpav@gmail.com>
Fri, 24 Apr 2015 11:43:45 +0000 (14:43 +0300)
committerPaul Fertser <fercerpav@gmail.com>
Fri, 24 Apr 2015 13:49:06 +0000 (14:49 +0100)
Since mqx comes last in the list, with the auto option its
update_threads is called even though it wasn't detected.

This check should be removed from all the rtos helpers and moved to
the generic code, but better do it later all in one go.

Change-Id: If24ab42a58a468d90e9f12028d4c2fb76a9bc2e8
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2741
Tested-by: jenkins
src/rtos/mqx.c

index a23a95c3487cd039e3254ea8fa030ed587cd49bd..0ba462c9a7b5f7723a8db4e9d5b9ed4ba897beeb 100644 (file)
@@ -292,6 +292,12 @@ static int mqx_update_threads(
        uint16_t task_queue_size = 0;
        uint32_t active_td_addr = 0;
 
+       if (!rtos->rtos_specific_params)
+               return -3;
+
+       if (!rtos->symbols)
+               return -4;
+
        /* clear old data */
        rtos_free_threadlist(rtos);
        /* check scheduler */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)