Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 128a733)
- Fixes '>=' whitespace
authorzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Tue, 23 Jun 2009 22:40:10 +0000 (22:40 +0000)
committerzwelch <zwelch@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Tue, 23 Jun 2009 22:40:10 +0000 (22:40 +0000)
- Replace ')\(>=\)\(\w\)' with ') \1 \2'.
- Replace '\(\w\)\(>=\)\(\w\)' with '\1 \2 \3'.

git-svn-id: svn://svn.berlios.de/openocd/trunk@2367 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/flash/ocl/at91sam7x/samflash.c patch | blob | history
src/helper/jim.c patch | blob | history
src/jtag/bitq.c patch | blob | history
src/jtag/presto.c patch | blob | history
src/target/arm720t.c patch | blob | history
src/target/arm7_9_common.c patch | blob | history
src/target/arm920t.c patch | blob | history
src/target/arm926ejs.c patch | blob | history
src/target/etm.h patch | blob | history
src/target/target.c patch | blob | history
src/target/xscale.c patch | blob | history

diff --git a/src/flash/ocl/at91sam7x/samflash.c b/src/flash/ocl/at91sam7x/samflash.c
index d7c21f72fa2344b96f30c3f17eceac89893b784b..66a857b39c332cc0d08f645ed77d8becf490d997 100644 (file)
--- a/src/flash/ocl/at91sam7x/samflash.c
+++ b/src/flash/ocl/at91sam7x/samflash.c
@@ -82,7 +82,7 @@ int flash_page_program(uint32 *data, int page_num)
        uint32 *data_ptr;
 
        /* select proper controller */
        uint32 *data_ptr;
 
        /* select proper controller */
-       if (page_num>=1024) efc_ofs=0x10;
+       if (page_num >= 1024) efc_ofs=0x10;
        else efc_ofs=0;
 
        /* wait until FLASH is ready, just for sure */
        else efc_ofs=0;
 
        /* wait until FLASH is ready, just for sure */
diff --git a/src/helper/jim.c b/src/helper/jim.c
index 99d3779ebcaf2c8145f63f868988041013f79ded..e5d2d4dc6e8651c896c56661fa50ee34d532702b 100644 (file)
--- a/src/helper/jim.c
+++ b/src/helper/jim.c
@@ -6956,7 +6956,7 @@ int Jim_EvalExpression(Jim_Interp *interp, Jim_Obj *exprObjPtr,
             case JIM_EXPROP_LT: wC = wA<wB; break;
             case JIM_EXPROP_GT: wC = wA>wB; break;
             case JIM_EXPROP_LTE: wC = wA<=wB; break;
             case JIM_EXPROP_LT: wC = wA<wB; break;
             case JIM_EXPROP_GT: wC = wA>wB; break;
             case JIM_EXPROP_LTE: wC = wA<=wB; break;
-            case JIM_EXPROP_GTE: wC = wA>=wB; break;
+            case JIM_EXPROP_GTE: wC = wA >= wB; break;
             case JIM_EXPROP_LSHIFT: wC = wA<<wB; break;
             case JIM_EXPROP_RSHIFT: wC = wA>>wB; break;
             case JIM_EXPROP_NUMEQ: wC = wA==wB; break;
             case JIM_EXPROP_LSHIFT: wC = wA<<wB; break;
             case JIM_EXPROP_RSHIFT: wC = wA>>wB; break;
             case JIM_EXPROP_NUMEQ: wC = wA==wB; break;
@@ -7061,7 +7061,7 @@ trydouble:
             case JIM_EXPROP_LT: dC = dA<dB; break;
             case JIM_EXPROP_GT: dC = dA>dB; break;
             case JIM_EXPROP_LTE: dC = dA<=dB; break;
             case JIM_EXPROP_LT: dC = dA<dB; break;
             case JIM_EXPROP_GT: dC = dA>dB; break;
             case JIM_EXPROP_LTE: dC = dA<=dB; break;
-            case JIM_EXPROP_GTE: dC = dA>=dB; break;
+            case JIM_EXPROP_GTE: dC = dA >= dB; break;
             case JIM_EXPROP_NUMEQ: dC = dA==dB; break;
             case JIM_EXPROP_NUMNE: dC = dA != dB; break;
             case JIM_EXPROP_LOGICAND_LEFT:
             case JIM_EXPROP_NUMEQ: dC = dA==dB; break;
             case JIM_EXPROP_NUMNE: dC = dA != dB; break;
             case JIM_EXPROP_LOGICAND_LEFT:
diff --git a/src/jtag/bitq.c b/src/jtag/bitq.c
index 0648446887585390e8d286a64e29d23f80c2d72c..1af1be5424ef92fcfc6422bed7902e7fa9f72f6e 100644 (file)
--- a/src/jtag/bitq.c
+++ b/src/jtag/bitq.c
@@ -370,7 +370,7 @@ int bitq_execute_queue(void)
                LOG_ERROR("missing data from bitq interface");
                return ERROR_JTAG_QUEUE_FAILED;
        }
                LOG_ERROR("missing data from bitq interface");
                return ERROR_JTAG_QUEUE_FAILED;
        }
-       if (bitq_interface->in()>=0)
+       if (bitq_interface->in() >= 0)
        {
                LOG_ERROR("extra data from bitq interface");
                return ERROR_JTAG_QUEUE_FAILED;
        {
                LOG_ERROR("extra data from bitq interface");
                return ERROR_JTAG_QUEUE_FAILED;
diff --git a/src/jtag/presto.c b/src/jtag/presto.c
index bd1cc5d441c80c3c61740436a7f53b29ac7d7c4f..8985cd76b1ccaa80c9cc68e0d4cbcbe7843616b1 100644 (file)
--- a/src/jtag/presto.c
+++ b/src/jtag/presto.c
@@ -652,14 +652,14 @@ static int presto_bitq_flush(void)
 
 static int presto_bitq_in_rdy(void)
 {
 
 static int presto_bitq_in_rdy(void)
 {
-       if (presto->buff_in_pos>=presto->buff_in_len)
+       if (presto->buff_in_pos >= presto->buff_in_len)
                return 0;
        return presto->buff_in_len-presto->buff_in_pos;
 }
 
 static int presto_bitq_in(void)
 {
                return 0;
        return presto->buff_in_len-presto->buff_in_pos;
 }
 
 static int presto_bitq_in(void)
 {
-       if (presto->buff_in_pos>=presto->buff_in_len)
+       if (presto->buff_in_pos >= presto->buff_in_len)
                return -1;
        if (presto->buff_in[presto->buff_in_pos++]&0x08) return 1;
        return 0;
                return -1;
        if (presto->buff_in[presto->buff_in_pos++]&0x08) return 1;
        return 0;
diff --git a/src/target/arm720t.c b/src/target/arm720t.c
index cdc5fd778e9cf852aa3f002ce8e33ec0c6546b9a..d709bacc1a37e770c60d99958328516b9ffb58a0 100644 (file)
--- a/src/target/arm720t.c
+++ b/src/target/arm720t.c
@@ -388,7 +388,7 @@ int arm720t_soft_reset_halt(struct target_s *target)
                {
                        break;
                }
                {
                        break;
                }
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        alive_sleep(100);
                } else
                {
                        alive_sleep(100);
                } else
diff --git a/src/target/arm7_9_common.c b/src/target/arm7_9_common.c
index 79b1bc745ea28ef7a9891841addb6b0e9dd22d71..692ab16f6a0e6327cc12278c268bece08b1359e0 100644 (file)
--- a/src/target/arm7_9_common.c
+++ b/src/target/arm7_9_common.c
@@ -711,7 +711,7 @@ int arm7_9_execute_sys_speed(struct target_s *target)
                if ((buf_get_u32(dbg_stat->value, EICE_DBG_STATUS_DBGACK, 1))
                                   && (buf_get_u32(dbg_stat->value, EICE_DBG_STATUS_SYSCOMP, 1)))
                        break;
                if ((buf_get_u32(dbg_stat->value, EICE_DBG_STATUS_DBGACK, 1))
                                   && (buf_get_u32(dbg_stat->value, EICE_DBG_STATUS_SYSCOMP, 1)))
                        break;
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        alive_sleep(100);
                } else
                {
                        alive_sleep(100);
                } else
@@ -1159,7 +1159,7 @@ int arm7_9_soft_reset_halt(struct target_s *target)
                embeddedice_read_reg(dbg_stat);
                if ((retval=jtag_execute_queue()) != ERROR_OK)
                        return retval;
                embeddedice_read_reg(dbg_stat);
                if ((retval=jtag_execute_queue()) != ERROR_OK)
                        return retval;
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        alive_sleep(100);
                } else
                {
                        alive_sleep(100);
                } else
diff --git a/src/target/arm920t.c b/src/target/arm920t.c
index 91107a5eb2d3fb6838f36695e035c9e920122d13..bf099e9dea1dd0d35e997f888a766769839267b3 100644 (file)
--- a/src/target/arm920t.c
+++ b/src/target/arm920t.c
@@ -587,7 +587,7 @@ int arm920t_soft_reset_halt(struct target_s *target)
                {
                        break;
                }
                {
                        break;
                }
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        /* do not eat all CPU, time out after 1 se*/
                        alive_sleep(100);
                {
                        /* do not eat all CPU, time out after 1 se*/
                        alive_sleep(100);
diff --git a/src/target/arm926ejs.c b/src/target/arm926ejs.c
index d53fc273bf6670a878e8317c7981aef54416a58a..5ffdeaff8bed99bd5cef5f69ab4ae37337cff3c4 100644 (file)
--- a/src/target/arm926ejs.c
+++ b/src/target/arm926ejs.c
@@ -587,7 +587,7 @@ int arm926ejs_soft_reset_halt(struct target_s *target)
                {
                        break;
                }
                {
                        break;
                }
-               if (debug_level>=1)
+               if (debug_level >= 1)
                {
                        /* do not eat all CPU, time out after 1 se*/
                        alive_sleep(100);
                {
                        /* do not eat all CPU, time out after 1 se*/
                        alive_sleep(100);
diff --git a/src/target/etm.h b/src/target/etm.h
index 22e24ec9c55bdb0b4ef86e6a160a9241a7111c1f..14dda4fcee895e9722bce0e6cb8cbff8afdc86fe 100644 (file)
--- a/src/target/etm.h
+++ b/src/target/etm.h
@@ -184,7 +184,7 @@ typedef enum
        BR_ENABLE  = 0x1, /* Trace has been enabled */
        BR_RESTART = 0x2, /* Trace restarted after a FIFO overflow */
        BR_NODEBUG = 0x3, /* ARM has exited for debug state */
        BR_ENABLE  = 0x1, /* Trace has been enabled */
        BR_RESTART = 0x2, /* Trace restarted after a FIFO overflow */
        BR_NODEBUG = 0x3, /* ARM has exited for debug state */
-       BR_PERIOD  = 0x4, /* Peridioc synchronization point (ETM>=v1.2)*/
+       BR_PERIOD  = 0x4, /* Peridioc synchronization point (ETM >= v1.2)*/
        BR_RSVD5   = 0x5, /* reserved */
        BR_RSVD6   = 0x6, /* reserved */
        BR_RSVD7   = 0x7, /* reserved */
        BR_RSVD5   = 0x5, /* reserved */
        BR_RSVD6   = 0x6, /* reserved */
        BR_RSVD7   = 0x7, /* reserved */
diff --git a/src/target/target.c b/src/target/target.c
index 781847fcb91d019eb3c4756aad27f8c7963a0965..b7685966f80283b856a76e0e171e1f732c780efb 100644 (file)
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -2279,7 +2279,7 @@ static int handle_load_image_command(struct command_context_s *cmd_ctx, char *cm
 
                /* DANGER!!! beware of unsigned comparision here!!! */
 
 
                /* DANGER!!! beware of unsigned comparision here!!! */
 
-               if ((image.sections[i].base_address+buf_cnt>=min_address)&&
+               if ((image.sections[i].base_address+buf_cnt >= min_address)&&
                                (image.sections[i].base_address<max_address))
                {
                        if (image.sections[i].base_address<min_address)
                                (image.sections[i].base_address<max_address))
                {
                        if (image.sections[i].base_address<min_address)
@@ -2955,7 +2955,7 @@ static int handle_profile_command(struct command_context_s *cmd_ctx, char *cmd,
                }
 
                gettimeofday(&now, NULL);
                }
 
                gettimeofday(&now, NULL);
-               if ((numSamples>=maxSample) || ((now.tv_sec >= timeout.tv_sec) && (now.tv_usec >= timeout.tv_usec)))
+               if ((numSamples >= maxSample) || ((now.tv_sec >= timeout.tv_sec) && (now.tv_usec >= timeout.tv_usec)))
                {
                        command_print(cmd_ctx, "Profiling completed. %d samples.", numSamples);
                        if ((retval = target_poll(target)) != ERROR_OK)
                {
                        command_print(cmd_ctx, "Profiling completed. %d samples.", numSamples);
                        if ((retval = target_poll(target)) != ERROR_OK)
@@ -4460,7 +4460,7 @@ static int handle_fast_load_image_command(struct command_context_s *cmd_ctx, cha
 
                /* DANGER!!! beware of unsigned comparision here!!! */
 
 
                /* DANGER!!! beware of unsigned comparision here!!! */
 
-               if ((image.sections[i].base_address+buf_cnt>=min_address)&&
+               if ((image.sections[i].base_address+buf_cnt >= min_address)&&
                                (image.sections[i].base_address<max_address))
                {
                        if (image.sections[i].base_address<min_address)
                                (image.sections[i].base_address<max_address))
                {
                        if (image.sections[i].base_address<min_address)
diff --git a/src/target/xscale.c b/src/target/xscale.c
index 7de1d84401955ccb836cad6974ef58250bee8ff9..71d365dd5ce5a2a1c76499a22b03b5e46649e4a2 100644 (file)
--- a/src/target/xscale.c
+++ b/src/target/xscale.c
@@ -499,7 +499,7 @@ int xscale_read_tx(target_t *target, int consume)
                {
                        goto done;
                }
                {
                        goto done;
                }
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        LOG_DEBUG("waiting 100ms");
                        alive_sleep(100); /* avoid flooding the logs */
                {
                        LOG_DEBUG("waiting 100ms");
                        alive_sleep(100); /* avoid flooding the logs */
@@ -580,7 +580,7 @@ int xscale_write_rx(target_t *target)
                }
                if (!(field0_in & 1))
                        goto done;
                }
                if (!(field0_in & 1))
                        goto done;
-               if (debug_level>=3)
+               if (debug_level >= 3)
                {
                        LOG_DEBUG("waiting 100ms");
                        alive_sleep(100); /* avoid flooding the logs */
                {
                        LOG_DEBUG("waiting 100ms");
                        alive_sleep(100); /* avoid flooding the logs */
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)