gdb_service_t -> struct gdb_service
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 16:06:52 +0000 (08:06 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 19:58:08 +0000 (11:58 -0800)
Remove misleading typedef and redundant suffix from struct gdb_service.

src/server/gdb_server.c
src/server/gdb_server.h

index 4d20a7dfee1fb22f4d1081efdbfa98508d9ab1cc..fe916c2677c2373a9906e5243b030a5a421fe3fb 100644 (file)
@@ -726,7 +726,7 @@ int gdb_target_callback_event_handler(struct target_s *target, enum target_event
 int gdb_new_connection(connection_t *connection)
 {
        struct gdb_connection *gdb_connection = malloc(sizeof(struct gdb_connection));
-       gdb_service_t *gdb_service = connection->service->priv;
+       struct gdb_service *gdb_service = connection->service->priv;
        int retval;
        int initial_ack;
 
@@ -781,7 +781,7 @@ int gdb_new_connection(connection_t *connection)
 
 int gdb_connection_closed(connection_t *connection)
 {
-       gdb_service_t *gdb_service = connection->service->priv;
+       struct gdb_service *gdb_service = connection->service->priv;
        struct gdb_connection *gdb_connection = connection->priv;
 
        /* we're done forwarding messages. Tear down callback before
@@ -1813,7 +1813,7 @@ int gdb_query_packet(connection_t *connection, target_t *target, char *packet, i
 int gdb_v_packet(connection_t *connection, target_t *target, char *packet, int packet_size)
 {
        struct gdb_connection *gdb_connection = connection->priv;
-       gdb_service_t *gdb_service = connection->service->priv;
+       struct gdb_service *gdb_service = connection->service->priv;
        int result;
 
        /* if flash programming disabled - send a empty reply */
@@ -1949,7 +1949,7 @@ int gdb_v_packet(connection_t *connection, target_t *target, char *packet, int p
 
 int gdb_detach(connection_t *connection, target_t *target)
 {
-       gdb_service_t *gdb_service = connection->service->priv;
+       struct gdb_service *gdb_service = connection->service->priv;
 
        target_call_event_callbacks(gdb_service->target, TARGET_EVENT_GDB_DETACH);
 
@@ -1984,7 +1984,7 @@ static void gdb_sig_halted(connection_t *connection)
 
 int gdb_input_inner(connection_t *connection)
 {
-       gdb_service_t *gdb_service = connection->service->priv;
+       struct gdb_service *gdb_service = connection->service->priv;
        target_t *target = gdb_service->target;
        char *packet = gdb_packet_buffer;
        int packet_size;
@@ -2197,7 +2197,7 @@ int gdb_input(connection_t *connection)
 
 int gdb_init(void)
 {
-       gdb_service_t *gdb_service;
+       struct gdb_service *gdb_service;
        target_t *target = all_targets;
 
        if (!target)
@@ -2216,7 +2216,7 @@ int gdb_init(void)
        {
                /* only a single gdb connection when using a pipe */
 
-               gdb_service = malloc(sizeof(gdb_service_t));
+               gdb_service = malloc(sizeof(struct gdb_service));
                gdb_service->target = target;
 
                add_service("gdb", CONNECTION_PIPE, 0, 1, gdb_new_connection, gdb_input, gdb_connection_closed, gdb_service);
@@ -2230,7 +2230,7 @@ int gdb_init(void)
 
                while (target)
                {
-                       gdb_service = malloc(sizeof(gdb_service_t));
+                       gdb_service = malloc(sizeof(struct gdb_service));
                        gdb_service->target = target;
 
                        add_service("gdb", CONNECTION_TCP,
index 239c50e02ede71a30b5512bdd265d4d33a1cc06d..ee9063b4f288fd3d23fc7943081893474a6b6f83 100644 (file)
@@ -49,10 +49,10 @@ struct gdb_connection
 
 };
 
-typedef struct gdb_service_s
+struct gdb_service
 {
        struct target_s *target;
-} gdb_service_t;
+};
 
 int gdb_init(void);
 int gdb_register_commands(command_context_t *command_context);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)