Jim_GetResult was called twice
authorVandra Akos <axos88@gmail.com>
Wed, 23 May 2012 10:47:55 +0000 (12:47 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Fri, 25 May 2012 12:11:57 +0000 (12:11 +0000)
Removed the superflous call to Jim_GetResult,
as we are reading in the result to a variable
anyways in the next instruction.

Change-Id: Idc96400737dc15e28304e97bcea79fa6c7a88ae1
Signed-off-by: Vandra Akos <axos88@gmail.com>
Reviewed-on: http://openocd.zylin.com/661
Tested-by: jenkins
Reviewed-by: √ėyvind Harboe <oyvindharboe@gmail.com>
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/server/tcl_server.c

index 30d55cb..94c3454 100644 (file)
@@ -129,9 +129,8 @@ static int tcl_input(struct connection *connection)
                        tclc->tc_line[tclc->tc_lineoffset-1] = '\0';
                        LOG_DEBUG("Executing script:\n %s", tclc->tc_line);
                        retval = Jim_Eval_Named(interp, tclc->tc_line, "remote:connection", 1);
-                       LOG_DEBUG("Result: %d\n %s", retval,
-                               Jim_GetString(Jim_GetResult(interp), &reslen));
                        result = Jim_GetString(Jim_GetResult(interp), &reslen);
+                       LOG_DEBUG("Result: %d\n %s", retval, result);
                        retval = tcl_output(connection, result, reslen);
                        if (retval != ERROR_OK)
                                return retval;