stlink: update to use ERROR_COMMAND_SYNTAX_ERROR
authorSpencer Oliver <spen@spen-soft.co.uk>
Wed, 4 Jan 2012 17:36:56 +0000 (17:36 +0000)
committerØyvind Harboe <oyvindharboe@gmail.com>
Wed, 4 Jan 2012 17:32:37 +0000 (17:32 +0000)
Change-Id: I21b669b09df65b56659d2f057cf389ba7b1cecfa
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/335
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
Tested-by: Øyvind Harboe <oyvindharboe@gmail.com>
src/target/stm32_stlink.c

index baa6b7488cea60ee11b23044bb6749d037270f8b..c39d4c80a50590d852d80196788bb51177f809c8 100644 (file)
@@ -98,7 +98,7 @@ static int stm32_stlink_load_core_reg_u32(struct target *target,
                break;
 
        default:
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        return ERROR_OK;
@@ -184,7 +184,7 @@ static int stm32_stlink_store_core_reg_u32(struct target *target,
                break;
 
        default:
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        return ERROR_OK;
@@ -225,7 +225,7 @@ static int stm32_stlink_target_create(struct target *target,
        struct cortex_m3_common *cortex_m3 = calloc(1, sizeof(struct cortex_m3_common));
 
        if (!cortex_m3)
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
 
        stm32_stlink_init_arch_info(target, cortex_m3, target->tap);
 
@@ -245,7 +245,7 @@ static int stm32_stlink_examine(struct target *target)
        if (target->tap->hasidcode == false) {
                LOG_ERROR("no IDCODE present on device");
 
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        if (!target_was_examined(target)) {
@@ -566,10 +566,10 @@ static int stm32_stlink_read_memory(struct target *target, uint32_t address,
        struct stlink_interface_s *stlink_if = target_to_stlink(target);
 
        if (!count || !buffer)
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        if (size != 4) {
                LOG_DEBUG("%s %x %d %d", __func__, address, size, count);
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        while (count) {
@@ -602,10 +602,10 @@ static int stm32_stlink_write_memory(struct target *target, uint32_t address,
        struct stlink_interface_s *stlink_if = target_to_stlink(target);
 
        if (!count || !buffer)
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        if (size != 4) {
                LOG_DEBUG("%s %x %d %d", __func__, address, size, count);
-               return ERROR_INVALID_ARGUMENTS;
+               return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
        while (count) {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)