flash: clarify protect documentation
authorØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 14 Dec 2010 08:29:26 +0000 (09:29 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 15 Dec 2010 08:48:37 +0000 (09:48 +0100)
some chips unprotect more than the range asked for. The
protect fn, must unprotect/protect minimally the range given.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/flash/nor/driver.h

index 3757442fcc8788206b4aa0c6f2074edab3ec1bad..cbf9c5282a2ce61bb2fc97950ba7c4a3c2d09e77 100644 (file)
@@ -105,9 +105,12 @@ struct flash_driver
 
        /**
         * Bank/sector protection routine (target-specific).
-        * When called, the driver should disable 'flash write' bits (or
-        * enable 'erase protection' bits) for the given @a bank and @a
-        * sectors.
+        *
+        * When called, the driver should enable/disable protection
+        * for MINIMUM the range covered by first..last sectors
+        * inclusive. Some chips have alignment requirements will
+        * cause the actual range to be protected / unprotected to
+        * be larger than the first..last range.
         *
         * @param bank The bank to protect or unprotect.
         * @param set If non-zero, enable protection; if 0, disable it.

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)