Don't include <helper/jim.h> from target.h ... not everything
which touches targets needs to be able to talk to Jim. Plus,
most files include this header by another path.
Also, switch the affected files to use the classic sequence
for #included files: all <framework/headers.h> first, then
the "local_headers.h". This helps prevent growth of problematic
layering, by minimizing entanglement.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
#include "config.h"
#endif
+#include <helper/time_support.h>
+#include <jtag/jtag.h>
+
#include "target.h"
#include "target_type.h"
#include "target_request.h"
#include "breakpoints.h"
-#include <helper/time_support.h>
#include "register.h"
#include "trace.h"
#include "image.h"
-#include <jtag/jtag.h>
static int target_array2mem(Jim_Interp *interp, struct target *target, int argc, Jim_Obj *const *argv);
#define TARGET_H
#include <helper/types.h>
-#include <helper/jim.h>
struct reg;
struct trace;
struct target_event_action {
enum target_event event;
- Jim_Interp *interp;
+ struct Jim_Interp *interp;
struct Jim_Obj *body;
int has_percent;
struct target_event_action *next;
#include "config.h"
#endif
+#include <helper/log.h>
+#include <helper/binarybuffer.h>
+
#include "target.h"
#include "target_request.h"
#include "target_type.h"
-#include <helper/binarybuffer.h>
#include "trace.h"
-#include <helper/log.h>
static int charmsg_mode = 0;
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
+
+#include <helper/log.h>
+
#include "target.h"
#include "target_type.h"
-#include <helper/log.h>
#include "hello.h"
static const struct command_registration testee_command_handlers[] = {
Linking to existing account procedure
If you already have an account and want to add another login method
you
MUST first sign in with your existing account and
then change URL to read
https://review.openocd.org/login/?link
to get to this page again but this time it'll work for linking. Thank you.
SSH host keys fingerprints
1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=.. |
|+o.. . |
|*.o . . |
|+B . . . |
|Bo. = o S |
|Oo.+ + = |
|oB=.* = . o |
| =+=.+ + E |
|. .=o . o |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)