Accept 64-bit addresses in CRC requests. 17/4317/3
authorTim Newsome <tim@sifive.com>
Tue, 26 Dec 2017 22:03:42 +0000 (14:03 -0800)
committerPaul Fertser <fercerpav@gmail.com>
Sat, 13 Jan 2018 09:52:13 +0000 (09:52 +0000)
Change-Id: I6a3e97ae8ffb4dc2ca1197a8102cb9ba34de0a1e
Signed-off-by: Tim Newsome <tim@sifive.com>
Reviewed-on: http://openocd.zylin.com/4317
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
src/server/gdb_server.c

index b2d13d72f5ac4afdbcd7331a0292590e11971bc1..f90f12bb5c805c3c86dabb38ccad71e3b44994dc 100644 (file)
@@ -2415,13 +2415,13 @@ static int gdb_query_packet(struct connection *connection,
                        char gdb_reply[10];
                        char *separator;
                        uint32_t checksum;
-                       uint32_t addr = 0;
+                       target_addr_t addr = 0;
                        uint32_t len = 0;
 
                        /* skip command character */
                        packet += 5;
 
-                       addr = strtoul(packet, &separator, 16);
+                       addr = strtoull(packet, &separator, 16);
 
                        if (*separator != ',') {
                                LOG_ERROR("incomplete read memory packet received, dropping connection");

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)