hla_interface: init trst, srst variables. 98/1698/2
authorSergey A. Borshch <sb-sf@users.sourceforge.net>
Fri, 18 Oct 2013 15:13:03 +0000 (18:13 +0300)
committerSpencer Oliver <spen@spen-soft.co.uk>
Tue, 29 Oct 2013 22:49:05 +0000 (22:49 +0000)
  There is an remark in jtag_srst and jtag_trst variables declaration:
  /*
   * JTAG adapters must initialize with TRST and SRST de-asserted
   * (they're negative logic, so that means *high*).  But some
   * hardware doesn't necessarily work that way ... so set things
   * up so that jtag_init() always forces that state.
   */

  but in hla_target such forsing is missed and both variables remains
  uninitialized until "reset" command issued, It prevents target polling
  when connecting to running target.

Change-Id: Ia620d8794cca8ba1403f5c5f24767e730033748a
Signed-off-by: Sergey A. Borshch <sb-sf@users.sourceforge.net>
Reviewed-on: http://openocd.zylin.com/1698
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Mathias K├╝ster <kesmtp@freenet.de>
src/jtag/hla/hla_interface.c

index 00e4549..02d0f2f 100644 (file)
@@ -137,6 +137,8 @@ int hl_interface_init_reset(void)
        if (hl_if.param.connect_under_reset) {
                jtag_add_reset(0, 1);
                hl_if.layout->api->assert_srst(hl_if.fd, 0);
+       } else {
+               jtag_add_reset(0, 0);
        }
 
        return ERROR_OK;