core arm11: Silence logs at level 3 if there is no activity
authorEdgar Grimberg <edgar.grimberg@zylin.com>
Mon, 25 Jan 2010 15:34:27 +0000 (16:34 +0100)
committerDavid Brownell <dbrownell@users.sourceforge.net>
Mon, 25 Jan 2010 20:19:52 +0000 (12:19 -0800)
If the target and openocd are idling, the log should normally
be silent at level 3.  (Given no verbose logging options.)

Signed-off-by: Edgar Grimberg <edgar.grimberg@zylin.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
src/jtag/core.c
src/target/arm11.c

index e311bfbcc8d5ce0ecfaee9d0dfa73c90bbead5fb..8a580e9e35e67215d17773debc4bcdd24bddcd3c 100644 (file)
@@ -530,10 +530,12 @@ int jtag_add_statemove(tap_state_t goal_state)
 {
        tap_state_t cur_state = cmd_queue_cur_state;
 
-       LOG_DEBUG("cur_state=%s goal_state=%s",
-               tap_state_name(cur_state),
-               tap_state_name(goal_state));
-
+       if (goal_state != cur_state)
+       {
+               LOG_DEBUG("cur_state=%s goal_state=%s",
+                       tap_state_name(cur_state),
+                       tap_state_name(goal_state));
+       }
 
        /* If goal is RESET, be paranoid and force that that transition
         * (e.g. five TCK cycles, TMS high).  Else trust "cur_state".
index 8b7b69c9cc3190aea41a4772c7ac3a16a553501a..671943f2b5b80083b7d122f77ce219ef2b07d4d1 100644 (file)
@@ -64,10 +64,10 @@ static int arm11_step(struct target *target, int current,
 static int arm11_check_init(struct arm11_common *arm11)
 {
        CHECK_RETVAL(arm11_read_DSCR(arm11));
-       LOG_DEBUG("DSCR %08x", (unsigned) arm11->dscr);
 
        if (!(arm11->dscr & DSCR_HALT_DBG_MODE))
        {
+               LOG_DEBUG("DSCR %08x", (unsigned) arm11->dscr);
                LOG_DEBUG("Bringing target into debug mode");
 
                arm11->dscr |= DSCR_HALT_DBG_MODE;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)